TOOLS-4278 Remove the last GoConvey from the repo - #1088
Draft
autarch wants to merge 1 commit into
Draft
Conversation
Converts TestFailDuringResharding and drops the goconvey dot-import from mongodump_test.go, which was the last one anywhere in mongo-tools. This function has no Reset, but GoConvey still re-ran the outer block per leaf, so each scenario got its own MongoDump. Sharing one across the subtests breaks five of the six, because Dump() closes the instance's session provider. The construction moves into a helper that each subtest calls. 35 assertions before and after, counting the six that were already testify and the two t.Fatalf calls. These subtests need -tags failpoints. Without it the no-op failpoint manager compiles in, DefaultManager.Get always returns false, and three of them fail with nothing to indicate why. The same applies to TestMongoDumpTOOLS2498. With the tag the package is green.
This was referenced Aug 6, 2026
Collaborator
Author
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts TestFailDuringResharding and drops the goconvey dot-import from
mongodump_test.go, which was the last one anywhere in mongo-tools.
This function has no Reset, but GoConvey still re-ran the outer block per
leaf, so each scenario got its own MongoDump. Sharing one across the
subtests breaks five of the six, because Dump() closes the instance's
session provider. The construction moves into a helper that each subtest
calls.
35 assertions before and after, counting the six that were already
testify and the two t.Fatalf calls.
These subtests need -tags failpoints. Without it the no-op failpoint
manager compiles in, DefaultManager.Get always returns false, and three
of them fail with nothing to indicate why. The same applies to
TestMongoDumpTOOLS2498. With the tag the package is green.