TOOLS-4278 Convert mongofiles write concern tests to testify - #1084
Draft
autarch wants to merge 1 commit into
Draft
Conversation
Converts TestDefaultWriteConcern's two Convey blocks to subtests. TestValidArguments above it was already testify, and TestMongoFilesCommands below it stays on GoConvey for now, so the dot-import remains. runPutIDTestCase sits just after this function in the file but is called only from TestMongoFilesCommands, so it is left for that conversion rather than taken by line position. This test already fails, before and after: it compares mf.ToolOptions.WriteConcern, a *wcwrapper.WriteConcern, against writeconcern.Majority(), which returns a *writeconcern.WriteConcern. The two can never be deeply equal regardless of the values inside. The failure is preserved exactly and recorded for follow-up. 4 assertions before and after. No behavior change.
This was referenced Aug 6, 2026
Collaborator
Author
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts TestDefaultWriteConcern's two Convey blocks to subtests.
TestValidArguments above it was already testify, and
TestMongoFilesCommands below it stays on GoConvey for now, so the
dot-import remains.
runPutIDTestCase sits just after this function in the file but is called
only from TestMongoFilesCommands, so it is left for that conversion
rather than taken by line position.
This test already fails, before and after: it compares
mf.ToolOptions.WriteConcern, a *wcwrapper.WriteConcern, against
writeconcern.Majority(), which returns a *writeconcern.WriteConcern. The
two can never be deeply equal regardless of the values inside. The
failure is preserved exactly and recorded for follow-up.
4 assertions before and after. No behavior change.