Skip to content

TOOLS-4278 Remove the last GoConvey from mongoimport - #1077

Draft
autarch wants to merge 1 commit into
TOOLS-4278-convey-to-testify-mongoimport-main-2from
TOOLS-4278-convey-to-testify-mongoimport-main-3
Draft

TOOLS-4278 Remove the last GoConvey from mongoimport#1077
autarch wants to merge 1 commit into
TOOLS-4278-convey-to-testify-mongoimport-main-2from
TOOLS-4278-convey-to-testify-mongoimport-main-3

Conversation

@autarch

@autarch autarch commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Converts TestHiddenOptionsDefaults and TestImportMIOSOE, the last two
Convey/So sites in the package, and drops the goconvey dot-import.
mongoimport is now entirely testify.

TestImportMIOSOE asserted ShouldNotBeNil twice on the same unmodified
err, so those collapse into one require.Error. Its two ShouldAlmostEqual
calls become InDelta, with the float64 on the delta as that signature
requires.

Tasks earlier in this stack each extracted a fixture-opening helper into
the file they were converting, and the three came out identical apart
from a few words of doc comment. They collapse here into one
openTestFixture in a new helpers_test.go, now that the whole package is
converted and the duplication is visible.

No behavior change.

Converts TestHiddenOptionsDefaults and TestImportMIOSOE, the last two
Convey/So sites in the package, and drops the goconvey dot-import.
mongoimport is now entirely testify.

TestImportMIOSOE asserted ShouldNotBeNil twice on the same unmodified
err, so those collapse into one require.Error. Its two ShouldAlmostEqual
calls become InDelta, with the float64 on the delta as that signature
requires.

Tasks earlier in this stack each extracted a fixture-opening helper into
the file they were converting, and the three came out identical apart
from a few words of doc comment. They collapse here into one
openTestFixture in a new helpers_test.go, now that the whole package is
converted and the duplication is visible.

No behavior change.

autarch commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@autarch

autarch commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

This PR does slightly more than its title says, and the extra part is deliberate.

Alongside converting the last GoConvey in mongoimport, it consolidates three fixture-opening helpers into one openTestFixture in a new helpers_test.go. Earlier PRs in this stack each extracted their own while converting a single file, and the three came out functionally identical, differing only in name. Deduping them here rather than in those PRs keeps each of them a single-file diff, and this is the point where the whole package is converted and the duplication is finally visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant