TOOLS-4278 Remove the last GoConvey from mongoimport - #1077
Draft
autarch wants to merge 1 commit into
Draft
Conversation
Converts TestHiddenOptionsDefaults and TestImportMIOSOE, the last two Convey/So sites in the package, and drops the goconvey dot-import. mongoimport is now entirely testify. TestImportMIOSOE asserted ShouldNotBeNil twice on the same unmodified err, so those collapse into one require.Error. Its two ShouldAlmostEqual calls become InDelta, with the float64 on the delta as that signature requires. Tasks earlier in this stack each extracted a fixture-opening helper into the file they were converting, and the three came out identical apart from a few words of doc comment. They collapse here into one openTestFixture in a new helpers_test.go, now that the whole package is converted and the duplication is visible. No behavior change.
This was referenced Aug 6, 2026
Collaborator
Author
This was referenced Aug 6, 2026
Collaborator
Author
|
This PR does slightly more than its title says, and the extra part is deliberate. Alongside converting the last GoConvey in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Converts TestHiddenOptionsDefaults and TestImportMIOSOE, the last two
Convey/So sites in the package, and drops the goconvey dot-import.
mongoimport is now entirely testify.
TestImportMIOSOE asserted ShouldNotBeNil twice on the same unmodified
err, so those collapse into one require.Error. Its two ShouldAlmostEqual
calls become InDelta, with the float64 on the delta as that signature
requires.
Tasks earlier in this stack each extracted a fixture-opening helper into
the file they were converting, and the three came out identical apart
from a few words of doc comment. They collapse here into one
openTestFixture in a new helpers_test.go, now that the whole package is
converted and the duplication is visible.
No behavior change.