TOOLS-4278 Convert mongorestore_test.go index tests to testify - #1082
Draft
autarch wants to merge 1 commit into
Draft
Conversation
Converts seven Test* functions, from TestMongorestoreMIOSOE through TestReadPreludeMetadata. TestFixHashedIndexes onward stays on GoConvey for now, so the dot-import remains. Assertion sites drop from 108 to 94. Both reductions are static only. TestReadPreludeMetadata's seven near-identical blocks become one table, which is 17 sites down to 5 while still running the same 29 assertions. TestDeprecatedIndexOptions loses two setup sites to a per-subtest helper: GoConvey re-ran the outer block per leaf, so each leaf built the other leaf's restore instance as well as its own. The helper's cleanup deletes with context.Background(), since t.Context() is cancelled before cleanups run, and asserts with assert rather than require so a failing drop doesn't skip the cleanups registered before it. MIOSOE's ShouldAlmostEqual becomes InDelta, and the duplicated-index prefix check becomes strings.HasPrefix. No behavior change.
This was referenced Aug 6, 2026
Collaborator
Author
This was referenced Aug 6, 2026
autarch
changed the title
Collaborator
Author
|
Retitled from "Convert mongorestore index and metadata tests" to name the file, because #1078 earlier in the stack is titled "…metadata and archive tests" and covers The commit message still carries the original wording; only the PR title changed, to avoid another force-push across the branches above this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts seven Test* functions, from TestMongorestoreMIOSOE through
TestReadPreludeMetadata. TestFixHashedIndexes onward stays on GoConvey
for now, so the dot-import remains.
Assertion sites drop from 108 to 94. Both reductions are static only.
TestReadPreludeMetadata's seven near-identical blocks become one table,
which is 17 sites down to 5 while still running the same 29 assertions.
TestDeprecatedIndexOptions loses two setup sites to a per-subtest helper:
GoConvey re-ran the outer block per leaf, so each leaf built the other
leaf's restore instance as well as its own.
The helper's cleanup deletes with context.Background(), since t.Context()
is cancelled before cleanups run, and asserts with assert rather than
require so a failing drop doesn't skip the cleanups registered before it.
MIOSOE's ShouldAlmostEqual becomes InDelta, and the duplicated-index
prefix check becomes strings.HasPrefix.
No behavior change.