TOOLS-4278 Convert mongodump oplog, query and view tests to testify - #1087
Draft
autarch wants to merge 1 commit into
Draft
TOOLS-4278 Convert mongodump oplog, query and view tests to testify#1087autarch wants to merge 1 commit into
autarch wants to merge 1 commit into
Conversation
Converts eight more functions in mongodump_test.go, leaving only TestFailDuringResharding on GoConvey, so the dot-import stays one more change. The five Reset calls become t.Cleanup registered where each one fired. The two view tests collapse from three Convey levels to one subtest level, with their shared setup extracted into helpers that register the teardown themselves. Counts that come back as int64 from the profiler are checked with Zero rather than compared against an untyped 0. Testify compares types, so an Equal or NotEqual against 0 there would be decided by the type difference rather than the value. TestMongoDumpTOOLS2498 still fails on the same failpoint lookup as before this change, and TestMongoDumpOplog is still skipped for TOOLS-2657, so its 17 assertions were converted without ever running. 86 assertions before and after. No behavior change.
This was referenced Aug 6, 2026
Collaborator
Author
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts eight more functions in mongodump_test.go, leaving only
TestFailDuringResharding on GoConvey, so the dot-import stays one more
change.
The five Reset calls become t.Cleanup registered where each one fired.
The two view tests collapse from three Convey levels to one subtest
level, with their shared setup extracted into helpers that register the
teardown themselves.
Counts that come back as int64 from the profiler are checked with Zero
rather than compared against an untyped 0. Testify compares types, so an
Equal or NotEqual against 0 there would be decided by the type
difference rather than the value.
TestMongoDumpTOOLS2498 still fails on the same failpoint lookup as
before this change, and TestMongoDumpOplog is still skipped for
TOOLS-2657, so its 17 assertions were converted without ever running.
86 assertions before and after. No behavior change.