TOOLS-4278 Convert mongodump BSON and metadata tests to testify - #1086
Draft
autarch wants to merge 1 commit into
Draft
TOOLS-4278 Convert mongodump BSON and metadata tests to testify#1086autarch wants to merge 1 commit into
autarch wants to merge 1 commit into
Conversation
Converts TestMongoDumpBSON, TestMongoDumpBSONLongCollectionName, TestDumpPreludeMetadataJson and TestMongoDumpMetaData, along with the three helpers they call. The rest of the file stays on GoConvey for now, so the dot-import remains. Thirteen Reset calls become t.Cleanup registered at the scope matching the leaves each one originally fired for. The prelude default-directory leaves each get their own removal rather than sharing one, and the "dump directory not created" case keeps its after-only cleanup, both matching the original. Cleanups use assert and delete with context.Background(), since t.Context() is cancelled before they run; that is why tearDownMongoDumpTestDataInCleanup exists alongside the t-taking version the unconverted tests still use. testDumpOneCollection's count check is NotZero rather than NotEqual against 0. restoredCount is an int64, and testify compares types, so NotEqual against an untyped 0 is satisfied by the type difference alone and passes even when nothing was restored. ShouldNotEqual was tolerant here and did fail. Assertion sites go from 133 to 130. The three fewer are unchecked Close and Drop calls in the long-collection-name test, which is skipped and which the original left unchecked. No behavior change.
This was referenced Aug 6, 2026
Collaborator
Author
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts TestMongoDumpBSON, TestMongoDumpBSONLongCollectionName,
TestDumpPreludeMetadataJson and TestMongoDumpMetaData, along with the
three helpers they call. The rest of the file stays on GoConvey for now,
so the dot-import remains.
Thirteen Reset calls become t.Cleanup registered at the scope matching
the leaves each one originally fired for. The prelude default-directory
leaves each get their own removal rather than sharing one, and the
"dump directory not created" case keeps its after-only cleanup, both
matching the original. Cleanups use assert and delete with
context.Background(), since t.Context() is cancelled before they run;
that is why tearDownMongoDumpTestDataInCleanup exists alongside the
t-taking version the unconverted tests still use.
testDumpOneCollection's count check is NotZero rather than NotEqual
against 0. restoredCount is an int64, and testify compares types, so
NotEqual against an untyped 0 is satisfied by the type difference alone
and passes even when nothing was restored. ShouldNotEqual was tolerant
here and did fail.
Assertion sites go from 133 to 130. The three fewer are unchecked Close
and Drop calls in the long-collection-name test, which is skipped and
which the original left unchecked.
No behavior change.