Skip to content

TOOLS-4278 Remove the last GoConvey from the repo #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
autarch wants to merge 1 commit into
base: TOOLS-4278-convey-to-testify-mongodump-2
Choose a base branch
from
Draft

TOOLS-4278 Remove the last GoConvey from the repo #1088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
322 changes: 195 additions & 127 deletions mongodump/mongodump_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ import (
"github.com/mongodb/mongo-tools/common/testtype"
"github.com/mongodb/mongo-tools/common/testutil"
"github.com/pkg/errors"
. "github.com/smartystreets/goconvey/convey"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.mongodb.org/mongo-driver/v2/bson"
Expand Down Expand Up @@ -2353,14 +2352,10 @@ func TestFailDuringResharding(t *testing.T) {
)

sessionProvider, _, err := testutil.GetBareSessionProvider()
if err != nil {
t.Fatalf("Failed to get session provider: %v", err)
}
require.NoError(t, err, "must get a session provider")

session, err := sessionProvider.GetSession()
if err != nil {
t.Fatalf("Failed to get session: %v", err)
}
require.NoError(t, err, "must get a session")

fcv := testutil.GetFCV(session)
if cmp, err := testutil.CompareFCV(fcv, "4.9"); err != nil || cmp < 0 {
Expand All @@ -2373,151 +2368,224 @@ func TestFailDuringResharding(t *testing.T) {
t.Skipf("Not for replica sets")
}

Convey("With a MongoDump instance", t, func() {
err := setUpMongoDumpTestData(t)
So(err, ShouldBeNil)
defaultErrorMsg := "detected resharding in progress. Cannot dump with --oplog while resharding"
oplogErrorMsg := "cannot dump with oplog while resharding"

md, err := simpleMongoDumpInstance()
So(err, ShouldBeNil)
t.Run("dump should fail if config.reshardingOperations exists on source", func(t *testing.T) {
md := newFailDuringReshardingMongoDump(t)
err = session.Database("config").CreateCollection(ctx, "reshardingOperations")
require.NoError(t, err, "should create the reshardingOperations collection")
//nolint:errcheck
defer session.Database("config").Collection("reshardingOperations").Drop(ctx)

md.OutputOptions.Oplog = true
md.ToolOptions.Namespace = &options.Namespace{}
err = md.Init()
So(err, ShouldBeNil)
err = md.Dump()
require.Error(t, err, "should refuse to dump while resharding is in progress")
assert.Contains(
t,
err.Error(),
defaultErrorMsg,
"should explain that resharding is in progress",
)
})

DefaultErrorMsg := "detected resharding in progress. Cannot dump with --oplog while resharding"
OplogErrorMsg := "cannot dump with oplog while resharding"
t.Run(
"dump should fail if config.localReshardingOperations.donor exists on source",
func(t *testing.T) {
md := newFailDuringReshardingMongoDump(t)
err = session.Database("config").
CreateCollection(ctx, "localReshardingOperations.donor")
require.NoError(t, err, "should create the localReshardingOperations.donor collection")
//nolint:errcheck
defer session.Database("config").
Collection("localReshardingOperations.donor").
Drop(ctx)

Convey("dump should fail if config.reshardingOperations exists on source", func() {
err = session.Database("config").CreateCollection(ctx, "reshardingOperations")
So(err, ShouldBeNil)
err = md.Dump()
require.Error(t, err, "should refuse to dump while resharding is in progress")
assert.Contains(
t,
err.Error(),
defaultErrorMsg,
"should explain that resharding is in progress",
)
},
)

t.Run(
"dump should fail if config.localReshardingOperations.recipient exists on source",
func(t *testing.T) {
md := newFailDuringReshardingMongoDump(t)
err = session.Database("config").
CreateCollection(ctx, "localReshardingOperations.recipient")
require.NoError(
t,
err,
"should create the localReshardingOperations.recipient collection",
)
//nolint:errcheck
defer session.Database("config").Collection("reshardingOperations").Drop(ctx)
defer session.Database("config").
Collection("localReshardingOperations.recipient").
Drop(ctx)

err = md.Dump()
So(err, ShouldNotBeNil)
So(err.Error(), ShouldContainSubstring, DefaultErrorMsg)
})
require.Error(t, err, "should refuse to dump while resharding is in progress")
assert.Contains(
t,
err.Error(),
defaultErrorMsg,
"should explain that resharding is in progress",
)
},
)

Convey(
"dump should fail if config.localReshardingOperations.donor exists on source",
func() {
err = session.Database("config").
CreateCollection(ctx, "localReshardingOperations.donor")
So(err, ShouldBeNil)
//nolint:errcheck
defer session.Database("config").
Collection("localReshardingOperations.donor").
Drop(ctx)

err = md.Dump()
So(err, ShouldNotBeNil)
So(err.Error(), ShouldContainSubstring, DefaultErrorMsg)
},
)
t.Run("dump should fail if config.reshardingOperations created in oplog", func(t *testing.T) {
md := newFailDuringReshardingMongoDump(t)
require.NoError(t, failpoint.DefaultManager.Parse(failpoint.PauseUntilResumed.String()))
defer failpoint.DefaultManager.Reset()

Convey(
"dump should fail if config.localReshardingOperations.recipient exists on source",
func() {
err = session.Database("config").
CreateCollection(ctx, "localReshardingOperations.recipient")
So(err, ShouldBeNil)
//nolint:errcheck
defer session.Database("config").
Collection("localReshardingOperations.recipient").
Drop(ctx)

err = md.Dump()
So(err, ShouldNotBeNil)
So(err.Error(), ShouldContainSubstring, DefaultErrorMsg)
},
dumpErrCh := make(chan error, 1)
go func() { dumpErrCh <- md.Dump() }()

fp, ok := failpoint.DefaultManager.Get(failpoint.PauseUntilResumed)
require.True(t, ok, "should find the PauseUntilResumed failpoint")
require.NoError(t, fp.Reached(context.TODO()))
sessErr1 := session.Database("config").CreateCollection(ctx, "reshardingOperations")
sessErr2 := session.Database("config").Collection("reshardingOperations").Drop(ctx)
fp.Signal()

err = <-dumpErrCh

require.Error(
t,
err,
"should refuse to dump while resharding is created during the oplog dump",
)
assert.Contains(
t,
err.Error(),
oplogErrorMsg,
"should explain that resharding is in progress",
)
assert.NoError(t, sessErr1, "should create the reshardingOperations collection")
assert.NoError(t, sessErr2, "should drop the reshardingOperations collection")
})

Convey("dump should fail if config.reshardingOperations created in oplog", func() {
require.NoError(t, failpoint.DefaultManager.Parse(failpoint.PauseUntilResumed.String()))
t.Run(
"dump should fail if config.localReshardingOperations.donor created in oplog",
func(t *testing.T) {
md := newFailDuringReshardingMongoDump(t)
require.NoError(
t,
failpoint.DefaultManager.Parse(failpoint.PauseUntilResumed.String()),
)
defer failpoint.DefaultManager.Reset()

dumpErrCh := make(chan error, 1)
go func() { dumpErrCh <- md.Dump() }()

fp, ok := failpoint.DefaultManager.Get(failpoint.PauseUntilResumed)
So(ok, ShouldBeTrue)
require.True(t, ok, "should find the PauseUntilResumed failpoint")
require.NoError(t, fp.Reached(context.TODO()))
sessErr1 := session.Database("config").CreateCollection(ctx, "reshardingOperations")
sessErr2 := session.Database("config").Collection("reshardingOperations").Drop(ctx)
sessErr1 := session.Database("config").
CreateCollection(ctx, "localReshardingOperations.donor")
sessErr2 := session.Database("config").
Collection("localReshardingOperations.donor").
Drop(ctx)
fp.Signal()

err = <-dumpErrCh

So(err, ShouldNotBeNil)
So(err.Error(), ShouldContainSubstring, OplogErrorMsg)
So(sessErr1, ShouldBeNil)
So(sessErr2, ShouldBeNil)
})
require.Error(
t,
err,
"should refuse to dump while resharding is created during the oplog dump",
)
assert.Contains(
t,
err.Error(),
oplogErrorMsg,
"should explain that resharding is in progress",
)
assert.NoError(
t,
sessErr1,
"should create the localReshardingOperations.donor collection",
)
assert.NoError(
t,
sessErr2,
"should drop the localReshardingOperations.donor collection",
)
},
)

Convey(
"dump should fail if config.localReshardingOperations.donor created in oplog",
func() {
require.NoError(
t,
failpoint.DefaultManager.Parse(failpoint.PauseUntilResumed.String()),
)
defer failpoint.DefaultManager.Reset()

dumpErrCh := make(chan error, 1)
go func() { dumpErrCh <- md.Dump() }()

fp, ok := failpoint.DefaultManager.Get(failpoint.PauseUntilResumed)
So(ok, ShouldBeTrue)
require.NoError(t, fp.Reached(context.TODO()))
sessErr1 := session.Database("config").
CreateCollection(ctx, "localReshardingOperations.donor")
sessErr2 := session.Database("config").
Collection("localReshardingOperations.donor").
Drop(ctx)
fp.Signal()

err = <-dumpErrCh

So(err, ShouldNotBeNil)
So(err.Error(), ShouldContainSubstring, OplogErrorMsg)
So(sessErr1, ShouldBeNil)
So(sessErr2, ShouldBeNil)
},
)
t.Run(
"dump should fail if config.localReshardingOperations.recipient created in oplog",
func(t *testing.T) {
md := newFailDuringReshardingMongoDump(t)
require.NoError(
t,
failpoint.DefaultManager.Parse(failpoint.PauseUntilResumed.String()),
)
defer failpoint.DefaultManager.Reset()

Convey(
"dump should fail if config.localReshardingOperations.recipient created in oplog",
func() {
require.NoError(
t,
failpoint.DefaultManager.Parse(failpoint.PauseUntilResumed.String()),
)
defer failpoint.DefaultManager.Reset()

dumpErrCh := make(chan error, 1)
go func() { dumpErrCh <- md.Dump() }()

fp, ok := failpoint.DefaultManager.Get(failpoint.PauseUntilResumed)
So(ok, ShouldBeTrue)
require.NoError(t, fp.Reached(context.TODO()))
sessErr1 := session.Database("config").
CreateCollection(ctx, "localReshardingOperations.recipient")
sessErr2 := session.Database("config").
Collection("localReshardingOperations.recipient").
Drop(ctx)
fp.Signal()

err = <-dumpErrCh

So(err, ShouldNotBeNil)
So(err.Error(), ShouldContainSubstring, OplogErrorMsg)
So(sessErr1, ShouldBeNil)
So(sessErr2, ShouldBeNil)
},
)
dumpErrCh := make(chan error, 1)
go func() { dumpErrCh <- md.Dump() }()

})
fp, ok := failpoint.DefaultManager.Get(failpoint.PauseUntilResumed)
require.True(t, ok, "should find the PauseUntilResumed failpoint")
require.NoError(t, fp.Reached(context.TODO()))
sessErr1 := session.Database("config").
CreateCollection(ctx, "localReshardingOperations.recipient")
sessErr2 := session.Database("config").
Collection("localReshardingOperations.recipient").
Drop(ctx)
fp.Signal()

err = <-dumpErrCh

require.Error(
t,
err,
"should refuse to dump while resharding is created during the oplog dump",
)
assert.Contains(
t,
err.Error(),
oplogErrorMsg,
"should explain that resharding is in progress",
)
assert.NoError(
t,
sessErr1,
"should create the localReshardingOperations.recipient collection",
)
assert.NoError(
t,
sessErr2,
"should drop the localReshardingOperations.recipient collection",
)
},
)
}

// builds a fresh MongoDump instance per subtest, since Dump closes the
// underlying session provider and a shared instance would only work once.
func newFailDuringReshardingMongoDump(t *testing.T) *MongoDump {
t.Helper()

err := setUpMongoDumpTestData(t)
require.NoError(t, err, "should set up the test data")

md, err := simpleMongoDumpInstance()
require.NoError(t, err, "should build a MongoDump instance")

md.OutputOptions.Oplog = true
md.ToolOptions.Namespace = &options.Namespace{}
err = md.Init()
require.NoError(t, err, "should initialize the MongoDump instance")

return md
}

func TestOptionsOrderIsPreserved(t *testing.T) {
Expand Down