TOOLS-4278 Convert mongorestore options and basic restore tests to testify - #1081
Draft
autarch wants to merge 1 commit into
Draft
Conversation
…stify Converts the first five Test* functions in mongorestore_test.go. The rest of the file stays on GoConvey for now, so the dot-import remains. Three fixture helpers replace the outer Convey blocks that built a restore and its collections. GoConvey rebuilt that setup for every leaf, so each subtest calls its own helper rather than sharing one instance. Assertion sites go from 119 to 124. All five extra sites are the same assertion appearing in more than one place rather than anything new: the getRestoreWithArgs check now lives in both the helper and the one subtest that builds its own restore, and the c1.Drop check is inlined into four subtests. Each still executes as many times as it did before. TestDeprecatedDBAndCollectionOptions has a subtest asserting the log buffer is empty, which ParseOptions pollutes with an unconditional "Setting num cpus" line. It fails when run alone and passes in a full package run, depending on the package-level log verbosity another test file leaves behind. Preserved as-is and recorded for follow-up alongside the related verbosity issue. No behavior change.
This was referenced Aug 6, 2026
Collaborator
Author
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the first five Test* functions in mongorestore_test.go. The rest
of the file stays on GoConvey for now, so the dot-import remains.
Three fixture helpers replace the outer Convey blocks that built a restore
and its collections. GoConvey rebuilt that setup for every leaf, so each
subtest calls its own helper rather than sharing one instance.
Assertion sites go from 119 to 124. All five extra sites are the same
assertion appearing in more than one place rather than anything new: the
getRestoreWithArgs check now lives in both the helper and the one subtest
that builds its own restore, and the c1.Drop check is inlined into four
subtests. Each still executes as many times as it did before.
TestDeprecatedDBAndCollectionOptions has a subtest asserting the log
buffer is empty, which ParseOptions pollutes with an unconditional
"Setting num cpus" line. It fails when run alone and passes in a full
package run, depending on the package-level log verbosity another test
file leaves behind. Preserved as-is and recorded for follow-up alongside
the related verbosity issue.
No behavior change.