TOOLS-4278 Remove the last GoConvey from mongofiles - #1085
Draft
autarch wants to merge 1 commit into
Draft
Conversation
Converts TestMongoFilesCommands and its runPutIDTestCase helper, and drops the goconvey dot-import. mongofiles is now entirely testify. This function had six Reset calls nested up to five deep over live GridFS state, which is the case where GoConvey's per-leaf re-execution actually matters: each Reset fired after every leaf beneath it. Each now becomes a t.Cleanup registered at the scope that matches the leaves the original covered. The get_regex cleanup in particular is registered inside each table case rather than at the parent, because parent registration would let the first case's files leak into the second. Cleanups use assert rather than require, so a failing teardown does not skip the cleanups registered before it, and they delete with context.Background() since t.Context() is cancelled before cleanups run. tearDownGridFSTestData no longer takes a *testing.T for that reason. Assertion sites drop from 173 to 140. The reduction is source duplication only: the Windows path-separator block was a verbatim copy of the plain one and now shares its two helpers, two get_regex scenarios share a table body, and the Reset file-removal bodies share one helper. Every distinct check still runs. One assertion looks wrong and is left that way: the content-comparison loop checks that the outer instance is non-nil rather than the one it "/home/autarch/bin/snip" run -- just built, so it cannot fail. Recorded for follow-up rather than fixed. No behavior change.
This was referenced Aug 6, 2026
Collaborator
Author
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts TestMongoFilesCommands and its runPutIDTestCase helper, and
drops the goconvey dot-import. mongofiles is now entirely testify.
This function had six Reset calls nested up to five deep over live GridFS
state, which is the case where GoConvey's per-leaf re-execution actually
matters: each Reset fired after every leaf beneath it. Each now becomes a
t.Cleanup registered at the scope that matches the leaves the original
covered. The get_regex cleanup in particular is registered inside each
table case rather than at the parent, because parent registration would
let the first case's files leak into the second.
Cleanups use assert rather than require, so a failing teardown does not
skip the cleanups registered before it, and they delete with
context.Background() since t.Context() is cancelled before cleanups run.
tearDownGridFSTestData no longer takes a *testing.T for that reason.
Assertion sites drop from 173 to 140. The reduction is source duplication
only: the Windows path-separator block was a verbatim copy of the plain
one and now shares its two helpers, two get_regex scenarios share a table
body, and the Reset file-removal bodies share one helper. Every distinct
check still runs.
One assertion looks wrong and is left that way: the content-comparison
loop checks that the outer instance is non-nil rather than the one it
"/home/autarch/bin/snip" run -- just built, so it cannot fail. Recorded for follow-up rather than fixed.
No behavior change.