TOOLS-4278 Convert mongoimport validation and reader tests to testify - #1075
Draft
autarch wants to merge 1 commit into
Draft
Conversation
Converts the first four Test* functions in mongoimport_test.go: TestSplitInlineHeader, TestMongoImportValidateSettings, TestGetSourceReader, and TestGetInputReader. The rest of the file stays on GoConvey for now, so the dot-import remains until the last of these tests is converted. The 247-line validation suite becomes one table. Three of its original Convey blocks called validateSettings() twice; each second call is independent of the first -- the earlier call either mutates only fields a fresh mock reproduces, or has its effect overwritten before the assertion -- so they split into separate rows without changing what is tested. Three cases are named for behavior they don't assert: one "an error should be thrown" and two "should complain" cases all assert no error. Preserved as-is with a comment, rather than fixed, to keep this a mechanical refactor. 55 runtime assertions before and after. No behavior change.
This was referenced Aug 6, 2026
Collaborator
Author
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the first four Test* functions in mongoimport_test.go:
TestSplitInlineHeader, TestMongoImportValidateSettings,
TestGetSourceReader, and TestGetInputReader. The rest of the file stays
on GoConvey for now, so the dot-import remains until the last of these
tests is converted.
The 247-line validation suite becomes one table. Three of its original
Convey blocks called validateSettings() twice; each second call is
independent of the first -- the earlier call either mutates only fields
a fresh mock reproduces, or has its effect overwritten before the
assertion -- so they split into separate rows without changing what is
tested.
Three cases are named for behavior they don't assert: one "an error
should be thrown" and two "should complain" cases all assert no error.
Preserved as-is with a comment, rather than fixed, to keep this a
mechanical refactor.
55 runtime assertions before and after. No behavior change.