SPIKE: Protocol 28 (CAP-0084)#307
Draft
sisuresh wants to merge 2 commits into
Draft
Conversation
Add SC_ADDRESS_TYPE_MUXED_CONTRACT arm and MuxedContract struct to SCAddress, gated behind #ifdef CAP_0084_MUXED_CONTRACT, mirroring the existing MuxedEd25519Account muxed-account pattern. Appears only in the `next` branch until core bumps the max supported protocol to 28. CAP-0084 (Muxed Contract Addresses): stellar/stellar-protocol#1968
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SC_ADDRESS_TYPE_MUXED_CONTRACTenum arm +MuxedContract { uint64 id; ContractID contractId; }struct +SCAddressunion arm toStellar-contract.x, all gated behind#ifdef CAP_0084_MUXED_CONTRACT, mirroring the existingMuxedEd25519Accountmuxed-account pattern.nextbranch (built--all-features) and stay out ofcurruntil core bumps max protocol to 28.curr/nextregenerate automatically on merge — not edited here.Stellar-ledger.xcomment revert (deliberate — reviewer please note): drops the unrelated Fix conflicting comment on rent fee #304 comment change so the p28 SPIKE XDR base stays byte-identical to the frozen p27 host (ledger.xhash93cdd4dd), avoiding downstream host-identity drift.Flag-token contract (downstream)
This repo is the root of the chain — no upstream. Downstreams pin this PR's head commit by full 40-char SHA:
787382ef2099cca168ca1cb282730d6b7b9e2f16(never the truncated787382e). The ifdef tokenCAP_0084_MUXED_CONTRACTis the verbatim contract for every downstream:cap_0084_muxed_contractXDR_FEATURES/xfile preprocess --features(go-stellar-sdk / js-stellar-base):CAP_0084_MUXED_CONTRACTA mismatched/truncated token silently strips the new types downstream.
Verification
Local
stellar-xdr xfile preprocess: arm absent with no features (curr); all three arms present and file parses with--features CAP_0084_MUXED_CONTRACT.Deferred
Downstream: stellar/rs-stellar-xdr#551 (pins this PR head
787382e)CAP-0084: stellar/stellar-protocol#1968