SPIKE: Protocol 28 (CAP-0084)#203
Draft
sisuresh wants to merge 4 commits into
Draft
Conversation
Re-pin go-stellar-sdk to the CAP-0084 regen (sisuresh/go@318bde14) which adds the SC_ADDRESS_TYPE_MUXED_CONTRACT arm. The SAC host de-muxes the destination and emits to_muxed_id as a uint64 (mirroring CAP-67 muxed accounts) for both transfer and mint, so horizon's existing V4 contractevents path already handles it; this documents that and adds regression tests.
This was referenced Jul 3, 2026
Contributor
Author
This was referenced Jul 3, 2026
- CHANGELOG: note Protocol 28 (CAP-0084) muxed-contract ingestion under Unreleased. - test-lcms: re-capture InvokeHostFunctionTests native/custom-asset LCM from a CAP-0084 vnext core build so TestCoreLCMIngestion exercises real muxed-contract SAC transfer/mint ledgers (surfacing to_muxed_id) end-to-end, not just P27 data. - horizon.yml: relabel the P28 leg CAP-0083 -> CAP-0084 and refresh the RPC tracking ref to stellar-rpc#837. Note: fixture captured from core #5337 built at 389ee9ee5 (one commit behind HEAD 4cdd2fc9e; delta is a host-submodule env re-pin). Muxed-id semantics still want human review - TestCoreLCMIngestion only asserts non-error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
MaxSupportedProtocolVersionto 28; pingo-stellar-sdkto the CAP-0084 branch (go-stellar-sdk#5961 HEADeeca7aa4).internal/ingest/contractevents/events.go: SAC transfer/mint to a muxed-contract destination surfaces the base contract in thetotopic and the mux id viato_muxed_id.contractevents/events_test.go("V4 transfer/mint to muxed contract (CAP-0084)").InvokeHostFunctionTestsnative/custom-assettest-lcmsfixtures from a CAP-0084 vnext core build soTestCoreLCMIngestioningests real muxed-contract ledgers end-to-end.[27, 28]; CHANGELOG entry under Unreleased.to_muxed_idsemantics:TestCoreLCMIngestiononly asserts ingestion is non-error, so the exact mux-id value is guarded only by the unit tests, not the fixture.Deferred
3589a696b): no-vnextimage/deb for CAP-0084 core (stellar-core#5337, HEAD4cdd2fc9e) is published yet. Fixture above was captured from a local #5337 build (at389ee9ee5, one commit behind HEAD; delta is a host-submodule env re-pin).""until stellar-rpc#837 publishes one.go-stellar-sdkreplace, un-draft, drop SPIKE) once go-stellar-sdk#5961 merges toprotocol-next.Upstream: stellar/go-stellar-sdk#5961 · stellar/stellar-core#5337 · stellar/stellar-rpc#837