SPIKE: Protocol 28 (CAP-0084 Muxed Contract Addresses)#551
Closed
sisuresh wants to merge 3 commits into
Closed
Conversation
Bump xdr submodule to stellar-xdr#306 head (7b56181), add the cap_0084_muxed_contract feature, and regenerate. Adds the SC_ADDRESS_TYPE_MUXED_CONTRACT arm on ScAddress and the MuxedContract struct, gated behind cap_0084_muxed_contract. str.rs: ScAddress Display is hand-written (CUSTOM_STR_IMPL); muxed contract addresses have no strkey encoding yet, so that arm returns Err — flagged for human review. Bumps crate version to 28.0.0.
Contributor
Author
|
Closing — opened with stale content by an interrupted automation turn; will be regenerated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
787382e(= head of stellar-xdr#307).cap_0084_muxed_contract; gatedVERSION.featuresentry.27.0.0→28.0.0.93cdd4dd(byte-identical to the frozen p27 host).Deferred
src/str.rsScAddress::MuxedContractDisplay/FromStr returnsErr— muxed-contract strkey encoding isn't instellar-strkeyyet (human-review flag).Upstream: stellar/stellar-xdr#307 (xdr pin
787382e)Draft — CI runs the feature-powerset matrix.