SPIKE: Protocol 28 (CAP-0084)#59
Draft
sisuresh wants to merge 5 commits into
Draft
Conversation
…d_contract Pin stellar-xdr git dep to rs-stellar-xdr#549 head (7b46a60d914c1e5befd6a2d2c50d2fdf7e5eb1f0) with the per-cap feature cap_0084_muxed_contract (+ cap_0083). xdr submodule = stellar-xdr#306 (7b561814…). Branch rebuilt on current main (v27.0.0). Add the CAP-0084 MuxedContract and StellarValueProposedValue variants to the tests/tests.rs type list to match #549's generated TypeVariant list.
…dup (SPIKE) The p28-cap-0084 SPIKE pins stellar-xdr to a git rev of rs-stellar-xdr#549, which cargo-deny's `sources` check rejects (unknown-git) and whose newer crate-git-revision (0.0.9) collides with stellar-strkey's 0.0.6 under the `bans` duplicate check. Add SPIKE-only allow-git + skip entries; revert both when rs-stellar-xdr releases and the pin flips from git= to version=.
This was referenced Jul 3, 2026
Author
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the XDR→JSON WASM for CAP-0084 (Muxed Contract Addresses).
Changes
cf7fdedf7ca95fccf45c82e6829d14637c9b5e4c(fork), features incl.cap_0084_muxed_contract.SC_ADDRESS_TYPE_MUXED_CONTRACTarm.deny.toml: alignedallow-gitto the pinned fork source (sisuresh/rs-stellar-xdr).CI notes
check-git-rev-deps/completeare RED by design: the SPIKE pins stellar-xdr to a git rev (rs-stellar-xdr#552, unreleased). Goes green once #552 merges + releases on crates.io and the pin flips toversion =. Not a blocker for the draft.cargo-deny (bans licenses sources)fixed by aligningdeny.tomlallow-gitto the pinned fork source.Deferred
version =, revertdeny.tomlallow-git = [], drop thecrate-git-revisionskip, re-enablewasm-opt.check-git-rev-depsgoes green then.Upstream
Related (P28 / CAP-0084 run)