feat: screen picker for windows desktop screen sharing#1124
Merged
Dadadah merged 3 commits intostoatchat:mainfrom Apr 30, 2026
Merged
feat: screen picker for windows desktop screen sharing#1124Dadadah merged 3 commits intostoatchat:mainfrom
Dadadah merged 3 commits intostoatchat:mainfrom
Conversation
Dadadah
force-pushed
the
feat/screenpicker
branch
2 times, most recently
from
bfec3c3 to
748b46c
Compare
Signed-off-by: Jacob Schlecht <[email protected]>
Dadadah
force-pushed
the
feat/screenpicker
branch
from
748b46c to
13419a6
Compare
7 tasks
Contributor
Maybe we could make this button red since this is a destructive button - to turn OFF the share
|
gabrielfordevelopment
added
ux review
Signed-off-by: Jacob Schlecht <[email protected]>
Signed-off-by: Jacob Schlecht <[email protected]>
chrishultin
approved these changes
Apr 29, 2026
infi
approved these changes
Apr 29, 2026
Contributor
infi
left a comment
infi
left a comment
There was a problem hiding this comment.
LGTM as per Stoat conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a screen picker modal that shows when a user initiates a screen share on Windows or Linux X11 using the desktop app. All other platforms, including Linux Wayland, do not use the screen picker modal.
Closes #1068
Requires stoatchat/for-desktop#207 (Not required for merge, but will not work until PR is merged and deployed to desktop)
Blocks #1070
Requires #1111How was this PR tested?
Screen share was initiated using a custom desktop build on Windows. Screen share was also tested on Linux Wayland and still works without the picker.
Screenshots & Screencasts
screencast.mp4
(This video is a bit choppy, that's due to the encoding. I had to make it smaller to upload it to github)
Checklist:
Please declare, if any, LLM usage involved in creating this PR
Generative AI was not used in the writing of this PR.