feat: add screenshare audio with muting capabilities#1055
Open
Dadadah wants to merge 4 commits into
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
8ccdc3a to
71f3ab0
Compare
680276a to
45907ea
Compare
91c70bf to
c137488
Compare
chrishultin
approved these changes
May 4, 2026
infi
approved these changes
May 9, 2026
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
bfe6e1c to
8a84b07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds audio to the screenshare functionality of Stoat. It also adds the ability to mute and change volume of streams. Audio is defaultly muted on screen shares to prevent surprises.
Audio does not work on Wayland Linux desktop. This is an Electron limitation.
Closes #1070
How was this PR tested?
Screen sharing was initiated with audio and without audio.
Screen sharing was muted by user, and then unmuted.
Screen sharing volume was adjusted up and down by user.
Screen sharing was cancelled by clicking button and by closing window.
Screenshots & Screencasts (if appropriate)
Screen share settings modal with new "Share Audio" checkbox

Screen share with audio

Screen share without audio

Screen share muted by user

Screen share context menu

Screen share audio checkbox also appears on the screen picker modal, but I am not on Windows and that's a pain for me to showcase. Just trust me bro 👍
Checklist:
Please declare, if any, LLM usage involved in creating this PR
Generative AI was not used in the writing of this PR.