Skip to content

feat: add screenshare audio with muting capabilities#1055

Open
Dadadah wants to merge 4 commits into
stoatchat:mainfrom
Dadadah:feat/screenshareaudio
Open

feat: add screenshare audio with muting capabilities#1055
Dadadah wants to merge 4 commits into
stoatchat:mainfrom
Dadadah:feat/screenshareaudio

Conversation

@Dadadah
Copy link
Copy Markdown
Member

@Dadadah Dadadah commented Mar 24, 2026

This PR adds audio to the screenshare functionality of Stoat. It also adds the ability to mute and change volume of streams. Audio is defaultly muted on screen shares to prevent surprises.

Audio does not work on Wayland Linux desktop. This is an Electron limitation.

Closes #1070

How was this PR tested?

Screen sharing was initiated with audio and without audio.
Screen sharing was muted by user, and then unmuted.
Screen sharing volume was adjusted up and down by user.
Screen sharing was cancelled by clicking button and by closing window.

Screenshots & Screencasts (if appropriate)

Screen share settings modal with new "Share Audio" checkbox
image

Screen share with audio
image

Screen share without audio
image

Screen share muted by user
image

Screen share context menu
image

Screen share audio checkbox also appears on the screen picker modal, but I am not on Windows and that's a pain for me to showcase. Just trust me bro 👍

Checklist:

  • I have carefully read the contributing guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR
  • I have confirmed that any new dependencies are strictly necessary
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code

Please declare, if any, LLM usage involved in creating this PR

Generative AI was not used in the writing of this PR.

@Dadadah Dadadah requested review from a team as code owners March 24, 2026 03:14
@Pecacheu

This comment was marked as outdated.

@Dadadah Dadadah marked this pull request as draft March 29, 2026 03:43
@Dadadah

This comment was marked as outdated.

@gabrielfordevelopment

This comment was marked as outdated.

@Dadadah

This comment was marked as outdated.

@Dadadah Dadadah marked this pull request as ready for review March 29, 2026 22:06
@Dadadah Dadadah marked this pull request as draft April 4, 2026 18:21
@Dadadah Dadadah force-pushed the feat/screenshareaudio branch 3 times, most recently from 8ccdc3a to 71f3ab0 Compare April 12, 2026 16:55
@Dadadah Dadadah force-pushed the feat/screenshareaudio branch 3 times, most recently from 680276a to 45907ea Compare April 19, 2026 21:30
@Dadadah Dadadah force-pushed the feat/screenshareaudio branch 2 times, most recently from 91c70bf to c137488 Compare May 3, 2026 05:05
@Dadadah Dadadah marked this pull request as ready for review May 3, 2026 05:50
Dadadah added 4 commits May 13, 2026 09:58
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
@Dadadah Dadadah force-pushed the feat/screenshareaudio branch from bfe6e1c to 8a84b07 Compare May 13, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add sound to screen sharing

5 participants