initial joint values for JointStateBroadcaster#2290
initial joint values for JointStateBroadcaster#2290christianrauch wants to merge 3 commits intoros-controls:masterfrom
Conversation
saikishor
left a comment
There was a problem hiding this comment.
Could you explain the motivation behind this change?
When your system only exposes |
7382999 to
09a9b58
Compare
saikishor
left a comment
There was a problem hiding this comment.
When your system only exposes
velocitystate interfaces, but you need thepositionfor therotor_state_broadcaster, it makes sense to initialise these values with 0, for example. This is akin to thejoint_state_publisher, which allows you to send 0 for joint values.
I understand the need. If this is what you need, then the intial value should be per joint name instead of everything together, so it is explicit
This seems a bit excessive to me. For a 7 DoF arm, this amounts to setting 21 values. You do not have to do this with the |
|
You only set those joints, who lack the feedback not for everything right? |
The initial values of the joints with feedback will be overridden anyway, so you can as well just set all joints at once. But I see your problem. I guess when a robot's default configuration is not all-0, then initialising all joints to the same value does not make sense. |
|
Moreover, 0 is a valid value and I don't think the JSB should initialise them to a valid value by default. There could be a case where 0 is not within your joint limits too. |
Description
Add new parameters to set the initial interface values for JointStateBroadcaster.
Fixes # (issue)
Is this user-facing behavior change?
Yes. It adds new parameters. The defaults stay the same, i.e. the default behaviour does not change.
Did you use Generative AI?
No.
Additional Information
The tests:
fail. But they currently also fail on
master(at least for me locally).TODOs
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)