Remove unused pWaitDstStageMask from Vulkan submit#1034
Remove unused pWaitDstStageMask from Vulkan submit#1034
Conversation
|
Let my double-check why this suddenly "fixes" some tests on the Windows GPU: |
d1e1277 to
095dd98
Compare
When putting up a PR the description should be the commit message. The git history during review inevitably collects various fixups, and burying the intended commit message there makes it hard to review the message itself. |
|
@bogner you're right, I've configured Claude to not have the useless |
`pWaitDstStageMask `is only meaningful when wait semaphores are used, which this submit path does not use. This wasn't causing errors in practice because` vkWaitForFences()` is called after every submit, preventing concurrent in-flight command buffers. The compute dispatch submit passed` VK_PIPELINE_STAGE_TRANSFER_BIT`, intending to wait for the prior buffer transfer submit to complete, but `pWaitDstStageMask `is a destination stage mask — it specifies which stages in the current submit to block until a wait semaphore signals, not which prior stages to wait on. Without semaphores this had no effect. Co-Authored-By: Claude Opus 4.6 <[email protected]>
6f552a6 to
ef175dd
Compare
pWaitDstStageMaskis only meaningful when wait semaphores are used, which this submit path does not use. This wasn't causing errors in practice becausevkWaitForFences()is called after every submit, preventing concurrent in-flight command buffers.The compute dispatch submit passed
VK_PIPELINE_STAGE_TRANSFER_BIT, intending to wait for the prior buffer transfer submit to complete, butpWaitDstStageMaskis a destination stage mask — it specifies which stages in the current submit to block until a wait semaphore signals, not which prior stages to wait on. Without semaphores this had no effect.