Implement an abstract Fence type to expose waiting for command buffer completion.#1007
Open
manon-traverse wants to merge 3 commits intollvm:mainfrom
Open
Implement an abstract Fence type to expose waiting for command buffer completion.#1007manon-traverse wants to merge 3 commits intollvm:mainfrom
manon-traverse wants to merge 3 commits intollvm:mainfrom
Conversation
Contributor
|
@manon-traverse - is this |
Contributor
|
#987 was merged, is it time to rebase this? |
MarijnS95
reviewed
Mar 30, 2026
MarijnS95
reviewed
Mar 30, 2026
MarijnS95
reviewed
Mar 30, 2026
Contributor
Author
@damyanp No it's mainly waiting for the metal-cpp update PR to get merged in: #1004 |
manon-traverse
force-pushed
the
render-backend-api-fence
branch
from
bcf1180 to
41f208f
Compare
damyanp
reviewed
Apr 1, 2026
Contributor
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
It's hard to convince myself this is the right abstraction since I don't think anything is actually using the abstraction - as far as I can tell, there isn't anything actually using the fence through the Fence interface?
Contributor
Author
The abstract is being used. However it is just being used for waiting for work completion by waiting on the signal value. Once @MarijnS95's work on command buffer submission on the queue is completed the Fence will be signaled by that function. Currently, the API-agnostic and API-specific code is fairly intertwined. As we get more of the graphics APIs covered in the API agnostic code this will become less of a problem. |
3 tasks
MarijnS95
added a commit
to Traverse-Research/offload-test-suite
that referenced
this pull request
Apr 1, 2026
Move command buffer submission logic from each backend's Device into Queue::submit(), which takes ownership of the command buffers. For now it blocks internally until completion; a TODO marks that it will return a Fence once the Fence abstraction from PR llvm#1007 is available. - Metal: commit + waitUntilCompleted + error check - Vulkan: vkEndCommandBuffer + temporary fence + vkQueueSubmit + wait - DX12: CmdList Close + ExecuteCommandLists + fence signal/wait VulkanQueue now stores a VkDevice handle (with a TODO for lifetime management) so it can create/destroy fences independently. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MarijnS95
added a commit
to Traverse-Research/offload-test-suite
that referenced
this pull request
Apr 2, 2026
Move command buffer submission logic from each backend's Device into Queue::submit(), which takes ownership of the command buffers. For now it blocks internally until completion; a TODO marks that it will return a Fence once the Fence abstraction from PR llvm#1007 is available. - Metal: commit + waitUntilCompleted + error check - Vulkan: vkEndCommandBuffer + temporary fence + vkQueueSubmit + wait - DX12: CmdList Close + ExecuteCommandLists + fence signal/wait VulkanQueue now stores a VkDevice handle (with a TODO for lifetime management) so it can create/destroy fences independently. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MarijnS95
added a commit
to Traverse-Research/offload-test-suite
that referenced
this pull request
Apr 2, 2026
Move command buffer submission logic from each backend's Device into Queue::submit(), which takes ownership of the command buffers. For now it blocks internally until completion; a TODO marks that it will return a Fence once the Fence abstraction from PR llvm#1007 is available. - Metal: commit + waitUntilCompleted + error check - Vulkan: vkEndCommandBuffer + temporary fence + vkQueueSubmit + wait - DX12: CmdList Close + ExecuteCommandLists + fence signal/wait VulkanQueue now stores a VkDevice handle (with a TODO for lifetime management) so it can create/destroy fences independently. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MarijnS95
added a commit
to Traverse-Research/offload-test-suite
that referenced
this pull request
Apr 2, 2026
Move command buffer submission logic from each backend's Device into Queue::submit(), which takes ownership of the command buffers. For now it blocks internally until completion; a TODO marks that it will return a Fence once the Fence abstraction from PR llvm#1007 is available. - Metal: commit() + waitUntilCompleted() - Vulkan: vkEndCommandBuffer() + vkQueueSubmit() with temporary fence + vkWaitForFences() - DX12: CmdList::Close() + ExecuteCommandLists() + Queue::Signal()/Fence::SetEventOnCompletion() wait VulkanQueue now stores a VkDevice handle (with a TODO for lifetime management) so it can create/destroy fences independently. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MarijnS95
added a commit
to Traverse-Research/offload-test-suite
that referenced
this pull request
Apr 2, 2026
Move command buffer submission logic from each backend's Device into Queue::submit(), which takes ownership of the command buffers. For now it blocks internally until completion; a TODO marks that it will return a Fence once the Fence abstraction from PR llvm#1007 is available. - Metal: commit() + waitUntilCompleted() - Vulkan: vkEndCommandBuffer() + vkQueueSubmit() with temporary fence + vkWaitForFences() - DX12: CmdList::Close() + ExecuteCommandLists() + Queue::Signal()/Fence::SetEventOnCompletion() wait VulkanQueue now stores a VkDevice handle (with a TODO for lifetime management) so it can create/destroy fences independently. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fence type is modeled around the DX12 Fence. The closest equivalent in Vulkan is a Timeline Semaphore. These are widely supported and included in Vulkan 1.2. Metal provides the same functionality through the SharedEvent type.
The abstract interface allows us to wait for GPU work to complete by waiting on a signal value using:
Fence->waitForCompletion(SignalValue);Signaling the value still requires downcasting because queue submission is not done via an abstract interface yet.