Skip to content

Remove unused pWaitDstStageMask from Vulkan submit #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manon-traverse merged 1 commit into from
Apr 7, 2026
+2 −4
Merged

Remove unused pWaitDstStageMask from Vulkan submit #1034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/API/VK/Device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,8 +1154,7 @@ class VulkanDevice : public offloadtest::Device {
return llvm::Error::success();
}

llvm::Error executeCommandBuffer(InvocationState &IS,
VkPipelineStageFlags WaitMask = 0) {
llvm::Error executeCommandBuffer(InvocationState &IS) {
if (vkEndCommandBuffer(IS.CmdBuffer))
return llvm::createStringError(std::errc::device_or_resource_busy,
"Could not end command buffer.");
Expand All @@ -1164,7 +1163,6 @@ class VulkanDevice : public offloadtest::Device {
SubmitInfo.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;
SubmitInfo.commandBufferCount = 1;
SubmitInfo.pCommandBuffers = &IS.CmdBuffer;
SubmitInfo.pWaitDstStageMask = &WaitMask;
VkFenceCreateInfo FenceInfo = {};
FenceInfo.sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO;
VkFence Fence;
Expand Down Expand Up @@ -2365,7 +2363,7 @@ class VulkanDevice : public offloadtest::Device {
if (auto Err = createCommands(P, State))
return Err;
llvm::outs() << "Commands created.\n";
if (auto Err = executeCommandBuffer(State, VK_PIPELINE_STAGE_TRANSFER_BIT))
if (auto Err = executeCommandBuffer(State))
return Err;
llvm::outs() << "Executed compute command buffer.\n";
if (auto Err = readBackData(P, State))
Expand Down
Loading