Skip to content
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kedro-datasets/kedro_datasets/plotly/html_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
filesystem (e.g.: local, S3, GCS).
"""
from __future__ import annotations

import os
from copy import deepcopy
from pathlib import PurePosixPath
from typing import Any, NoReturn
Expand Down Expand Up @@ -53,7 +53,7 @@ class HTMLDataset(AbstractVersionedDataset[go.Figure, go.Figure | go.FigureWidge
def __init__( # noqa: PLR0913
self,
*,
filepath: str,
filepath: str | os.PathLike,
save_args: dict[str, Any] | None = None,
version: Version | None = None,
credentials: dict[str, Any] | None = None,
Expand Down
4 changes: 2 additions & 2 deletions kedro-datasets/kedro_datasets/plotly/json_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
filesystem (e.g.: local, S3, GCS).
"""
from __future__ import annotations

import os
import json
from copy import deepcopy
from pathlib import PurePosixPath
Expand Down Expand Up @@ -59,7 +59,7 @@ class JSONDataset(AbstractVersionedDataset[go.Figure, go.Figure | go.FigureWidge
def __init__( # noqa: PLR0913
self,
*,
filepath: str,
filepath: str | os.PathLike,
load_args: dict[str, Any] | None = None,
save_args: dict[str, Any] | None = None,
version: Version | None = None,
Expand Down
4 changes: 2 additions & 2 deletions kedro-datasets/kedro_datasets/plotly/plotly_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
plotly figure.
"""
from __future__ import annotations

import os
import json
from copy import deepcopy
from typing import Any
Expand Down Expand Up @@ -70,7 +70,7 @@ class PlotlyDataset(JSONDataset):
def __init__( # noqa: PLR0913
self,
*,
filepath: str,
filepath: str | os.PathLike,
plotly_args: dict[str, Any],
load_args: dict[str, Any] | None = None,
save_args: dict[str, Any] | None = None,
Expand Down
2 changes: 1 addition & 1 deletion kedro-datasets/tests/plotly/test_html_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

@pytest.fixture
def filepath_html(tmp_path):
return (tmp_path / "test.html").as_posix()
return tmp_path / "test.html"


@pytest.fixture
Expand Down
2 changes: 1 addition & 1 deletion kedro-datasets/tests/plotly/test_json_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

@pytest.fixture
def filepath_json(tmp_path):
return (tmp_path / "test.json").as_posix()
return tmp_path / "test.json"


@pytest.fixture
Expand Down
2 changes: 1 addition & 1 deletion kedro-datasets/tests/plotly/test_plotly_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

@pytest.fixture
def filepath_json(tmp_path):
return (tmp_path / "test.json").as_posix()
return tmp_path / "test.json"


@pytest.fixture
Expand Down
Loading