Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kedro-datasets/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
| `opik.OpikEvaluationDataset` | A dataset for managing Opik evaluation datasets. | `kedro_datasets_experimental.opik` |

## Bug fixes and other changes
- Added `os.PathLike` support for `plotly` datasets.
## Community contributions

- [Datascienceio](https://github.com/datascienceio)
# Release 9.3.0

## Major features and improvements
Expand Down
3 changes: 2 additions & 1 deletion kedro-datasets/kedro_datasets/plotly/html_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"""
from __future__ import annotations

import os
from copy import deepcopy
from pathlib import PurePosixPath
from typing import Any, NoReturn
Expand Down Expand Up @@ -53,7 +54,7 @@ class HTMLDataset(AbstractVersionedDataset[go.Figure, go.Figure | go.FigureWidge
def __init__( # noqa: PLR0913
self,
*,
filepath: str,
filepath: str | os.PathLike,
save_args: dict[str, Any] | None = None,
version: Version | None = None,
credentials: dict[str, Any] | None = None,
Expand Down
3 changes: 2 additions & 1 deletion kedro-datasets/kedro_datasets/plotly/json_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from __future__ import annotations

import json
import os
from copy import deepcopy
from pathlib import PurePosixPath
from typing import Any
Expand Down Expand Up @@ -59,7 +60,7 @@ class JSONDataset(AbstractVersionedDataset[go.Figure, go.Figure | go.FigureWidge
def __init__( # noqa: PLR0913
self,
*,
filepath: str,
filepath: str | os.PathLike,
load_args: dict[str, Any] | None = None,
save_args: dict[str, Any] | None = None,
version: Version | None = None,
Expand Down
3 changes: 2 additions & 1 deletion kedro-datasets/kedro_datasets/plotly/plotly_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from __future__ import annotations

import json
import os
from copy import deepcopy
from typing import Any

Expand Down Expand Up @@ -70,7 +71,7 @@ class PlotlyDataset(JSONDataset):
def __init__( # noqa: PLR0913
self,
*,
filepath: str,
filepath: str | os.PathLike,
plotly_args: dict[str, Any],
load_args: dict[str, Any] | None = None,
save_args: dict[str, Any] | None = None,
Expand Down
2 changes: 1 addition & 1 deletion kedro-datasets/tests/plotly/test_html_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

@pytest.fixture
def filepath_html(tmp_path):
return (tmp_path / "test.html").as_posix()
return tmp_path / "test.html"


@pytest.fixture
Expand Down
2 changes: 1 addition & 1 deletion kedro-datasets/tests/plotly/test_json_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

@pytest.fixture
def filepath_json(tmp_path):
return (tmp_path / "test.json").as_posix()
return tmp_path / "test.json"


@pytest.fixture
Expand Down
2 changes: 1 addition & 1 deletion kedro-datasets/tests/plotly/test_plotly_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

@pytest.fixture
def filepath_json(tmp_path):
return (tmp_path / "test.json").as_posix()
return tmp_path / "test.json"


@pytest.fixture
Expand Down
Loading