chore(datasets): Path related term #1375
Merged
ElenaKhaustova merged 14 commits intokedro-org:mainfrom Apr 21, 2026
Merged
Conversation
Signed-off-by: datascienceio <[email protected]>
Signed-off-by: datascienceio <[email protected]>
Signed-off-by: datascienceio <[email protected]>
Signed-off-by: datascienceio <[email protected]>
Signed-off-by: datascienceio <[email protected]>
Signed-off-by: datascienceio <[email protected]>
6 tasks
Contributor
ElenaKhaustova
left a comment
ElenaKhaustova
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @datascienceio! The type annotation and test fixture changes look correct. A couple of things to fix before we can merge:
- Import formatting — blank line after
from __future__ import annotationsis removed in all 3 source files; it needs to be preserved. - Import ordering — import os should come after import json alphabetically in
json_dataset.pyandplotly_dataset.py. - Missing RELEASE.md entry.
- Issue reference — #1375 references #1316 (
ensure os.PathLike works) but the changes also address #1317 (update type annotations/docstrings). It would be good to reference both, or at least #1317 since the type annotation update is the primary change.
Contributor
Author
|
Hi Elena, thank you for the information. Will update this. Kind regards |
Signed-off-by: datascienceio <[email protected]>
Signed-off-by: datascienceio <[email protected]>
Signed-off-by: datascienceio <[email protected]>
Signed-off-by: datascienceio <[email protected]>
Updated filepath type for Plotly information in Kedro-datasets to evaluate Path directly instead of string, removing posix-related term. Signed-off-by: datascienceio <[email protected]>
Contributor
Author
|
Hi, I've updated the files. Thankyou |
Contributor
ElenaKhaustova
left a comment
ElenaKhaustova
left a comment
There was a problem hiding this comment.
Thank you, @datascienceio!
Left minor suggestions on RELEASE.md formatting, otherwise looks good 👍
Co-authored-by: ElenaKhaustova <[email protected]> Signed-off-by: datascienceio <[email protected]>
Co-authored-by: ElenaKhaustova <[email protected]> Signed-off-by: datascienceio <[email protected]>
Contributor
Author
|
I've clicked to add the suggestions, thanks |
Contributor
Author
|
Thank you! |
iwhalen
pushed a commit
to iwhalen/kedro-plugins
that referenced
this pull request
Apr 22, 2026
* Update filepath type to support os.PathLike Signed-off-by: datascienceio <[email protected]> * Update filepath type to support os.PathLike Signed-off-by: datascienceio <[email protected]> * Update filepath type to support os.PathLike Signed-off-by: datascienceio <[email protected]> * Simplify filepath_html fixture return statement Signed-off-by: datascienceio <[email protected]> * Refactor filepath_json fixture to remove as_posix Signed-off-by: datascienceio <[email protected]> * Refactor filepath_json fixture return statement Signed-off-by: datascienceio <[email protected]> * Add future annotations import to html_dataset.py Signed-off-by: datascienceio <[email protected]> * Add import statement for future annotations Signed-off-by: datascienceio <[email protected]> * Update json_dataset.py Signed-off-by: datascienceio <[email protected]> * Reorder import statements in plotly_dataset.py Signed-off-by: datascienceio <[email protected]> * Fix filepath type for Plotly information in RELEASE.md Updated filepath type for Plotly information in Kedro-datasets to evaluate Path directly instead of string, removing posix-related term. Signed-off-by: datascienceio <[email protected]> * Update kedro-datasets/RELEASE.md Co-authored-by: ElenaKhaustova <[email protected]> Signed-off-by: datascienceio <[email protected]> * Apply suggestion from @ElenaKhaustova Co-authored-by: ElenaKhaustova <[email protected]> Signed-off-by: datascienceio <[email protected]> --------- Signed-off-by: datascienceio <[email protected]> Co-authored-by: ElenaKhaustova <[email protected]> Signed-off-by: iwhalen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completed Plotly subtask for #1316 and #1317
Development notes
Directly evaluate Path rather than string , hence posix-related term was deleted.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
jsonschema/kedro-catalog-X.XX.jsonif necessaryRELEASE.mdfile