feat(inputs.azure_monitor): Support secrets for client_secret#18744
Merged
skartikey merged 7 commits intoMay 14, 2026
Merged
Conversation
Use config.Secret for client_secret to support secret stores. Follows pattern from mysql plugin.
- Add TestInit_NoClientID and TestInit_NoTenantID tests - Update Gather tests to resolve config.Secret before use - Follow pattern from telegraf-private
Validate subscription_id, client_id, and tenant_id are not empty before initializing the Azure client. Use errors.New for consistency with other telegraf plugins.
superguillen
changed the title
telegraf-tiger
Bot
added
feat
srebhan
changed the title
srebhan
reviewed
Apr 22, 2026
Member
srebhan
left a comment
srebhan
left a comment
There was a problem hiding this comment.
Thanks for your contribution @superguillen! Please find my comments in the code.
Co-authored-by: Sven Rebhan <[email protected]>
Co-authored-by: Sven Rebhan <[email protected]>
srebhan
added
area/azure
2 tasks
skartikey
reviewed
May 11, 2026
Contributor
skartikey
left a comment
skartikey
left a comment
There was a problem hiding this comment.
@superguillen Thanks! Please take a look at the comments.
Scope client_id and tenant_id checks to the client_secret path so DefaultAzureCredential setups (managed identity, workload identity, env credentials, Azure CLI) keep working without those fields. Document secret-store support for client_secret in README and sample.conf, and consolidate duplicate mock branches in the metric definitions client test.
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
skartikey
approved these changes
May 14, 2026
Contributor
|
@superguillen Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Related issues
resolves #18743