Skip to content

feat(inputs.azure_monitor): Support secrets for client_secret #18744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skartikey merged 7 commits into from
May 14, 2026
Merged

feat(inputs.azure_monitor): Support secrets for client_secret #18744

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e4e644c
feat(inputs.azure_monitor): add secret support for client_secret
superguillen Apr 18, 2026
12a4136
test(inputs.azure_monitor): update tests for config.Secret
superguillen Apr 19, 2026
a5d4f54
fix(inputs.azure_monitor): add required field validation
superguillen Apr 19, 2026
b06b9ae
Update plugins/inputs/azure_monitor/azure_monitor.go
superguillen Apr 23, 2026
db931da
Update plugins/inputs/azure_monitor/azure_monitor.go
superguillen Apr 23, 2026
1677df4
test(azure_monitor): use Init for azure monitor gather tests
superguillen Apr 27, 2026
e4e5cfc
fix(inputs.azure_monitor): address review feedback on secret support
skartikey May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions plugins/inputs/azure_monitor/azure_monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package azure_monitor

import (
_ "embed"
"errors"
"fmt"
"sync"

Expand All @@ -12,13 +13,14 @@ import (
receiver "github.com/logzio/azure-monitor-metrics-receiver"

"github.com/influxdata/telegraf"
"github.com/influxdata/telegraf/config"
"github.com/influxdata/telegraf/plugins/inputs"
)

type AzureMonitor struct {
SubscriptionID string `toml:"subscription_id"`
ClientID string `toml:"client_id"`
ClientSecret string `toml:"client_secret"`
ClientSecret config.Secret `toml:"client_secret"`
Comment thread
skartikey marked this conversation as resolved.
TenantID string `toml:"tenant_id"`
CloudOption string `toml:"cloud_option,omitempty"`
ResourceTargets []*resourceTarget `toml:"resource_target"`
Expand Down Expand Up @@ -63,6 +65,16 @@ func (*AzureMonitor) SampleConfig() string {
}

func (am *AzureMonitor) Init() error {
if am.SubscriptionID == "" {
return errors.New("subscription_id is required")
}
if am.ClientID == "" {
return errors.New("client_id is required")
}
if am.TenantID == "" {
return errors.New("tenant_id is required")
}
Comment thread
skartikey marked this conversation as resolved.
Outdated

var clientOptions azcore.ClientOptions
switch am.CloudOption {
case "AzureChina":
Expand All @@ -75,8 +87,18 @@ func (am *AzureMonitor) Init() error {
return fmt.Errorf("unknown cloud option: %s", am.CloudOption)
}

var clientSecret string
if !am.ClientSecret.Empty() {
secret, err := am.ClientSecret.Get()
if err != nil {
return err
Comment thread
superguillen marked this conversation as resolved.
Outdated
}
clientSecret = secret.String()
defer secret.Destroy()
Comment thread
superguillen marked this conversation as resolved.
Outdated
}

var err error
am.azureClients, err = am.azureManager.createAzureClients(am.SubscriptionID, am.ClientID, am.ClientSecret, am.TenantID, clientOptions)
am.azureClients, err = am.azureManager.createAzureClients(am.SubscriptionID, am.ClientID, clientSecret, am.TenantID, clientOptions)
if err != nil {
return err
}
Expand Down
70 changes: 66 additions & 4 deletions plugins/inputs/azure_monitor/azure_monitor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,36 @@ func TestInit_NoSubscriptionID(t *testing.T) {
require.Error(t, am.Init())
}

func TestInit_NoClientID(t *testing.T) {
file, err := os.ReadFile("testdata/toml/init_no_client_id.toml")
require.NoError(t, err)
require.NotNil(t, file)
require.NotEmpty(t, file)

var am *AzureMonitor
require.NoError(t, toml.Unmarshal(file, &am))

am.Log = testutil.Logger{}
am.azureManager = &mockAzureClientsManager{}

require.Error(t, am.Init())
}

func TestInit_NoTenantID(t *testing.T) {
file, err := os.ReadFile("testdata/toml/init_no_tenant_id.toml")
require.NoError(t, err)
require.NotNil(t, file)
require.NotEmpty(t, file)

var am *AzureMonitor
require.NoError(t, toml.Unmarshal(file, &am))

am.Log = testutil.Logger{}
am.azureManager = &mockAzureClientsManager{}

require.Error(t, am.Init())
}

func TestInit_NoTargets(t *testing.T) {
file, err := os.ReadFile("testdata/toml/init_no_targets.toml")
require.NoError(t, err)
Expand Down Expand Up @@ -911,10 +941,18 @@ func TestGather_Success(t *testing.T) {
resourceTargets = append(resourceTargets, receiver.NewResourceTarget(target.ResourceID, target.Metrics, target.Aggregations))
}

var clientSecret string
if !am.ClientSecret.Empty() {
clientSecretValue, err := am.ClientSecret.Get()
require.NoError(t, err)
clientSecret = clientSecretValue.String()
defer clientSecretValue.Destroy()
}

Comment thread
srebhan marked this conversation as resolved.
Outdated
var clientOptions = azcore.ClientOptions{Cloud: cloud.AzurePublic}

var azureClients *receiver.AzureClients
azureClients, err = am.azureManager.createAzureClients(am.SubscriptionID, am.ClientID, am.ClientSecret, am.TenantID, clientOptions)
azureClients, err = am.azureManager.createAzureClients(am.SubscriptionID, am.ClientID, clientSecret, am.TenantID, clientOptions)
require.NoError(t, err)
require.NotNil(t, azureClients)

Expand Down Expand Up @@ -998,10 +1036,18 @@ func TestGather_China_Success(t *testing.T) {
resourceTargets = append(resourceTargets, receiver.NewResourceTarget(target.ResourceID, target.Metrics, target.Aggregations))
}

var clientSecret string
if !am.ClientSecret.Empty() {
clientSecretValue, err := am.ClientSecret.Get()
require.NoError(t, err)
clientSecret = clientSecretValue.String()
defer clientSecretValue.Destroy()
}

var clientOptions = azcore.ClientOptions{Cloud: cloud.AzureChina}

var azureClients *receiver.AzureClients
azureClients, err = am.azureManager.createAzureClients(am.SubscriptionID, am.ClientID, am.ClientSecret, am.TenantID, clientOptions)
azureClients, err = am.azureManager.createAzureClients(am.SubscriptionID, am.ClientID, clientSecret, am.TenantID, clientOptions)
require.NoError(t, err)
require.NotNil(t, azureClients)

Expand Down Expand Up @@ -1031,10 +1077,18 @@ func TestGather_Government_Success(t *testing.T) {
resourceTargets = append(resourceTargets, receiver.NewResourceTarget(target.ResourceID, target.Metrics, target.Aggregations))
}

var clientSecret string
if !am.ClientSecret.Empty() {
clientSecretValue, err := am.ClientSecret.Get()
require.NoError(t, err)
clientSecret = clientSecretValue.String()
defer clientSecretValue.Destroy()
}

var clientOptions = azcore.ClientOptions{Cloud: cloud.AzureGovernment}

var azureClients *receiver.AzureClients
azureClients, err = am.azureManager.createAzureClients(am.SubscriptionID, am.ClientID, am.ClientSecret, am.TenantID, clientOptions)
azureClients, err = am.azureManager.createAzureClients(am.SubscriptionID, am.ClientID, clientSecret, am.TenantID, clientOptions)
require.NoError(t, err)
require.NotNil(t, azureClients)

Expand Down Expand Up @@ -1064,10 +1118,18 @@ func TestGather_Public_Success(t *testing.T) {
resourceTargets = append(resourceTargets, receiver.NewResourceTarget(target.ResourceID, target.Metrics, target.Aggregations))
}

var clientSecret string
if !am.ClientSecret.Empty() {
clientSecretValue, err := am.ClientSecret.Get()
require.NoError(t, err)
clientSecret = clientSecretValue.String()
defer clientSecretValue.Destroy()
}

var clientOptions = azcore.ClientOptions{Cloud: cloud.AzurePublic}

var azureClients *receiver.AzureClients
azureClients, err = am.azureManager.createAzureClients(am.SubscriptionID, am.ClientID, am.ClientSecret, am.TenantID, clientOptions)
azureClients, err = am.azureManager.createAzureClients(am.SubscriptionID, am.ClientID, clientSecret, am.TenantID, clientOptions)
require.NoError(t, err)
require.NotNil(t, azureClients)

Expand Down
Loading