feat(inputs.azure_monitor): support secret stores for client_secret#18815
Closed
goehou wants to merge 10 commits into
Closed
feat(inputs.azure_monitor): support secret stores for client_secret#18815goehou wants to merge 10 commits into
goehou wants to merge 10 commits into
Conversation
- metric.go:103: RemoveField comment said 'removes the tag' but should be 'removes the field' - metric.go:112: 'an unique' should be 'a unique' (grammar) - parser.go:38: Comment said 'GetParser' but should be 'SetParserFunc' to match the method name
- metric.go:103: RemoveField comment said removes the tag but should be removes the field - metric.go:112: an unique should be a unique grammar - parser.go:38: Comment said GetParser but should be SetParserFunc to match the method name
fix: correct documentation comments in metric.go and parser.go
telegraf-tiger
Bot
added
feat
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1: #16483
Title
docs(inputs.internal): document internal_write input series
Body
Summary
Document the
internal_writeseries emitted by the internal input itself.The internal input can report its own startup status as an
internal_writemeasurement tagged withinput=internal. This series was missing from the plugin README, which only documented the output-plugininternal_writeseries tagged withoutput=<plugin_name>.This change adds documentation for the
internal_write,input=internalseries and includes it in the example output.Checklist
Related Issues
resolves #16483
PR 2: #18743
Title
feat(inputs.azure_monitor): support secret stores for client_secret
Body
Summary
Add secret-store support for the Azure Monitor input
client_secretoption.The Azure Monitor input previously stored
client_secretas a plain string. This prevented users from referencing Telegraf secret stores for Azure client secret authentication.This change updates
client_secretto useconfig.Secretand resolves the secret during initialization before creating the Azure clients.Tests were added to verify:
client_secretcan resolve values from a secret-store referenceDocumentation and sample configuration were updated to mention secret-store support for
client_secret.Checklist
Related Issues
resolves #18743