fix(ci): correct stale Helm repository URLs in Release Charts workflow - #17
Merged
Merged
Conversation
Assisted-by: Devin:claude-sonnet-4.5 Co-Authored-By: benchan <ben@vervious.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #16
Why are the changes needed?
The
Release Chartsworkflow — the chart-releaser job that publishes to gh-pages, i.e. the only thing that puts charts onhttps://exa-labs.github.io/flyte— has been failing on every push to master since at least the #14 merge in June. It dies in the "Add required Helm repositories" step, before chart-releaser ever runs, so gh-pages has been frozen atflyte-binary v0.1.10.Two of the three repository URLs it adds no longer exist:
Neither is what the charts actually declare.
charts/flyte-sandbox/Chart.yaml(andvalidate-helm-charts.yaml, which is why chart validation still passes) point at the live URLs. This went unnoticed because nothing needed a newly published chart until now —flyte-binary v0.1.11was merged in #16 and never made it to the index.What changes were proposed in this pull request?
Point the two stale URLs at the ones the charts declare:
Bitnami is left alone — see testing below.
Out of scope: the separate
Package & Push Flyte Helm Chartsworkflow also fails, withUsername and password required, becauseFLYTE_BOT_USERNAME/FLYTE_BOT_PATaren't set on this fork. That's an upstream GHCR dev-chart path we don't consume, and it's a secrets gap rather than something a diff can fix.How was this patch tested?
Ran the corrected step's exact command sequence locally, then resolved dependencies for both charts:
helm lintpasses on both charts.Bitnami was checked explicitly rather than assumed, since Bitnami has been retiring its legacy chart index:
https://charts.bitnami.com/bitnami302-redirects torepo.broadcom.combut still serves a validindex.yaml, and both pinned versions (minio 12.6.7,postgresql 12.8.1) download as valid archives. It works today, but it is a redirect away from breaking this workflow the same way.The real verification is the next push to master:
v0.1.11should appear inhttps://exa-labs.github.io/flyte/index.yaml.Labels
fixed
Check all the applicable boxes
Related PRs
flyte-binary v0.1.11is stuck unpublished because of this.Link to Devin session: https://app.devin.ai/sessions/137e980b425d43668660198d80b6e21d
Requested by: @Vervious