fix(ci): skip existing chart releases so the Helm index actually publishes - #18
Merged
Merged
Conversation
Assisted-by: Devin:claude-sonnet-4.5 Co-Authored-By: benchan <ben@vervious.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Assisted-by: Devin:claude-sonnet-4.5 Co-Authored-By: benchan <ben@vervious.com>
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #16, #17
Why are the changes needed?
Release Chartsstill fails after #17, and this is the deeper reason the gh-pages index has been frozen at April 2025.crreleases every chart undercharts/, but only the chart you actually bumped has a new version. Everything else is still at the version released on 2025-04-23, socr uploadfails on the first unchanged chart:That exits 1 before the
cr index --pushstep, so the gh-pages index is never regenerated. Every run since that first successful publish was guaranteed to fail this way — #17's dead repository URLs were failing earlier in the job and masking it.The last run shows how close it gets: packaging succeeded for all six charts, and the release was created —
— but
https://exa-labs.github.io/flyte/index.yamlstill advertises onlyv0.1.10, so nothing can consume the chart.What changes were proposed in this pull request?
Two independent one-liners in
.github/workflows/github-helm-charts.yaml:skip_existing: trueonhelm/chart-releaser-action@v1.6.0. The wrapper maps it tocr upload --skip-existing, so unchanged charts are skipped rather than failing the run, andcr index --push(which the wrapper runs unconditionally afterwards) regenerates the index from the GitHub releases — which already includeflyte-binary-v0.1.11.token: ${{ secrets.GITHUB_TOKEN }}onazure/setup-helm@v3, fixing an unrelated warning in the same job:The action needs the token to resolve
latest; without it the Helm version silently pins to a hardcoded fallback.How was this patch tested?
Not locally testable —
Release Chartsonly runs on push to master, and the failure is incr's interaction with the GitHub Releases API, which can't be reproduced from a workstation.Verified instead against
helm/chart-releaser-action@v1.6.0thatskip_existingis a real input on the pinned version, that it maps tocr upload --skip-existing, and that the wrapper invokescr index --pushunconditionally after upload (so skipped uploads don't skip indexing). Likewise confirmedtokenis a supported input onazure/setup-helm@v3.The verification that matters is the next push to master: the run should go green and
v0.1.11should appear inhttps://exa-labs.github.io/flyte/index.yaml.Labels
fixed
Check all the applicable boxes
Related PRs
flyte-binary v0.1.11is packaged and released but still absent from the index.Link to Devin session: https://app.devin.ai/sessions/137e980b425d43668660198d80b6e21d
Requested by: @Vervious