fix(ci): create the chart index workspace before running cr index - #20
Merged
Merged
Conversation
Assisted-by: Devin:claude-sonnet-4.5 Co-Authored-By: benchan <ben@vervious.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #19
Why are the changes needed?
The index regeneration step added in #19 fails on master:
The step does
rm -rf .cr-index .cr-release-packagesbut only recreates.cr-release-packages.cr indexwrites its output via a temporary suffixed file next to--index-pathand does not create that parent directory itself, so the write fails.Everything before that point worked:
crv1.6.1 installed, theorigin/gh-pagesworktree was prepared, and all seven release packages were downloaded and inspected includingflyte-binary-v0.1.11.tgz. Soflyte-binaryv0.1.11 is still missing from the published index.What changes were proposed in this pull request?
How was this patch tested?
Release Chartsonly runs on push to master, and #19's local verification passed only because it ran in a working tree that already had.cr-index— so this time the workflow's own shell was tested rather than an adaptation of it.Both
run:blocks were extracted verbatim from the committed workflow and executed in separate clean clones, with only the Actions environment stubbed (GITHUB_REPOSITORY,GITHUB_REPOSITORY_OWNER,RUNNER_TEMP,GITHUB_PATH,CR_TOKEN/GH_TOKEN,CHART_RELEASER_VERSION),$GITHUB_PATHapplied between steps, and the final--pushflag dropped so gh-pages is untouched.At
origin/masterthe harness reproduces the CI failure exactly:At this branch it succeeds:
The clean clones had no
origin/gh-pagesref, so the step's explicit fetch path was exercised too. Walking the rest of the step in that harness surfaced no other dependency on pre-existing local state.Labels
fixed
Related PRs
Release Chartsfailuresflyte-binaryv0.1.11 chart waiting on publicationLink to Devin session: https://app.devin.ai/sessions/137e980b425d43668660198d80b6e21d
Requested by: @Vervious