Repository navigation
feat: add configuration integrity checks - #1140
codewithchotu wants to merge 5 commits into
Conversation
👷 Deploy request for ap-template-playground pending review.Visit the deploys page to approve it
|
I, Mohd Owais <mo0322975@gmail.com>, hereby add my Signed-off-by to this commit: d9098d2 Signed-off-by: Mohd Owais <mo0322975@gmail.com>
E2E Testing UpdateHi @mttrbrts!
The initial failure appears timing-related, but I haven't confirmed its root cause. I wanted to document this rather than report an unconditional E2E pass. |
|
Thank you for opening this, and for the detail in the description and in your E2E note. A configuration integrity check that runs before npm ci is a sensible addition, and the 22 scanner tests are a good start. Because this PR changes the GitHub Actions workflows, its CI runs are waiting for a maintainer to approve them before they start, as is usual for pull requests from forks. Once they run, a maintainer for this repository will review the scanner, its thresholds and the workflow changes, and review comments will appear on this pull request. Posted automatically by Mira, an Accord Project agent. A maintainer will follow up; they make the decisions on this. |
Thanks for the update! I understand that the workflow runs require maintainer approval. I'll wait for CI to run and will address any feedback from the review. Appreciate the guidance! |
There was a problem hiding this comment.
Thanks for this. The scanner is small and readable, uses only Node built-ins, runs git ls-files through execFileSync with fixed arguments, and runs before npm ci, so it adds no new dependencies or permissions. The tests cover the thresholds and edge cases well. Two things should change before merge: the 22 scanner tests need to run in CI, and the PR should be clear that a check running from the PR's own checkout can't stop a hostile PR. Because this changes GitHub Actions workflows, it also needs a maintainer's approval.
Nothing blocking; some suggestions below. Findings: 2 should-fix, 1 nit.
Automated review by Mira, an Accord Project agent, at 1fa0d63. Findings are labelled blocking, should-fix or nit; a maintainer makes the final call.
Signed-off-by: Mohd Owais <mo0322975@gmail.com>
… into security/config-integrity-guard
|
Thanks for the review! I've addressed all three points:
Verified all 22 scanner tests pass, and the existing unit tests also pass. The updates have been pushed. |
Summary
Introduces a lightweight configuration integrity scanner to help identify suspicious content in sensitive repository files, motivated by the security incident described in #1101.
Changes
scripts/check-config-integrity.mjs.npm ci.Validation
git diff --check: passed.Note: The repository-wide ESLint command currently reports existing violations across
src/. The new scanner and its tests are outside the configured ESLint target.Security considerations
This is a heuristic early-warning check, not a malware detector or security boundary. It can identify suspicious formatting patterns but cannot detect every form of malicious code. PR review and existing maintainer approval controls remain essential.
Related issue
Related to #1101.
Feedback on detection thresholds, sensitive-file coverage, and CI integration is welcome.