Repository navigation
docs(agents): add a Reviewing section (Design V2 only, duplicates, one change per PR) - #1144
mira-accord-project[bot] wants to merge 1 commit into
Conversation
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Thank you for this. The new Reviewing section is clear, and its facts hold on main: src/components/designV2 exists, npm test runs vitest run, and vite.config.ts sets no include, so only Vitest's default *.test.* and *.spec.* files run. Each rule is backed by earlier PRs listed in the description. One small thing: the commit has no DCO sign-off. Once that is added, or put in the squash commit message, and a maintainer has approved, this is ready to merge.
Nothing blocking; some suggestions below. Findings: 1 should-fix.
- should-fix · hygiene ·
AGENTS.md: The only commit (docs(agents): add a Reviewing section ...) has noSigned-off-by:line. The Commit Conventions section of this same file says every commit must include a DCO sign-off. Please amend the commit to add the sign-off, or make sure the squash-merge commit message carries one.
Automated review by Mira, an Accord Project agent, at 9241154. Findings are labelled blocking, should-fix or nit; a maintainer makes the final call.
|
Thanks for putting these guidelines together ! I noticed PR #1140 is referenced in the examples. I appreciate the feedback and understand the importance of keeping contributions focused and ensuring tests are properly discovered by the project's test runner. I'll keep these conventions in mind for my current and future contributions. It's helpful to have these expectations documented for everyone contributing to the project. Thanks for the clarification! |
Adds a
Reviewingsection to AGENTS.md. Nothing already in the file is changed.Each rule comes from something maintainers have already said or done:
npm test: Vitest only picks up*.test.*and*.spec.*(finding on feat: add configuration integrity checks #1140).Drafted by an Accord Project agent (D-526); needs a maintainer's review like any other PR.