Skip to content

fix: teardown blocks indefinitely when a reconnect thread is active and the robot is unreachable (#368)#519

Open
urrsk wants to merge 9 commits into
masterfrom
fix/rtde-reconnect-thread-blocking-destructor
Open

fix: teardown blocks indefinitely when a reconnect thread is active and the robot is unreachable (#368)#519
urrsk wants to merge 9 commits into
masterfrom
fix/rtde-reconnect-thread-blocking-destructor

refactor(TCPSocket): express stop via SocketState instead of a boolean

9025946
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 17, 2026 in 0s

72.14% (-6.73%) compared to ca25b13

View this Pull Request on Codecov

72.14% (-6.73%) compared to ca25b13

Details

Codecov Report

❌ Patch coverage is 80.00000% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.14%. Comparing base (ca25b13) to head (9025946).
⚠️ Report is 5 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/comm/tcp_socket.cpp 77.14% 1 Missing and 15 partials ⚠️
include/ur_client_library/comm/producer.h 66.66% 0 Missing and 3 partials ⚠️
src/comm/tcp_server.cpp 86.66% 1 Missing and 1 partial ⚠️
include/ur_client_library/comm/stream.h 85.71% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (ca25b13) and HEAD (9025946). Click for more details.

HEAD has 217 uploads less than BASE
Flag BASE (ca25b13) HEAD (9025946)
start_ursim 8 1
check_version_ur5-3.15.8 8 1
check_version_ur15-5.25.1 8 1
check_version_ur30-5.25.1 8 1
check_version_ur16e-5.25.1 8 1
check_version_ur10e-5.15.2 8 1
check_version_ur10-3.15.8 8 1
check_version_ur3-3.14.3 8 1
check_version_ur7e-5.22.2 8 1
check_version_ur3e-5.9.4 8 1
check_version_ur20-5.25.1 8 1
check_version_ur18-5.25.1 8 1
check_version_ur5e-5.12.8 8 1
check_version_ur12e-5.25.1 8 1
check_version_ur8long-5.25.1 8 1
check_version_ur8long-10.12.1 8 1
check_version_ur10e-10.11.0 8 1
check_version_ur18-10.12.1 8 1
check_version_ur30-10.12.1 8 1
check_version_ur7e-10.11.0 8 1
check_version_ur15-10.12.1 8 1
check_version_ur20-10.12.1 8 1
check_version_ur3e-10.11.0 8 1
check_version_ur12e-10.12.1 8 1
check_version_ur16e-10.12.1 8 1
check_version_ur5e-10.11.0 8 1
ur5e-10.7.0 8 1
ur5e-10.11.0 8 1
ur5e-10.12.0 8 1
ur5e-5.9.4 6 0
ur5-3.14.3 8 0
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   78.87%   72.14%   -6.73%     
==========================================
  Files         116      115       -1     
  Lines        6612     6825     +213     
  Branches     2920     3004      +84     
==========================================
- Hits         5215     4924     -291     
- Misses       1031     1543     +512     
+ Partials      366      358       -8

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

View more details on Codecov