Repository navigation
fix(helm): accept KMS alias ARNs in the collector and keep the role ARN commercial - #72
Closed
tim-thacker-nullify wants to merge 1 commit into
Closed
tim-thacker-nullify wants to merge 1 commit into
tim-thacker-nullify wants to merge 1 commit into
Conversation
…RN commercial - collector.kms.keyArn accepts arn:aws:kms:<region>:<account>:alias/<name> and key ARNs including multi-Region key/mrk-..., matching the connector CloudFormation AllowedPattern. The region default and check take the region from either form. - NOTES warns when an alias is used: IAM matches the key ARN, so the role needs the connector stack version that also grants key/*; the Terraform module grants only the given ARN. - The role-arn guard is back to arn:aws:iam:: only; Nullify's bucket and key are commercial-partition. serviceAccount.requireRoleArn=false stays the escape hatch. ci/eks-govcloud-role.yaml is removed. - CI: ci/eks-kms-alias.yaml and ci/eks-kms-mrk.yaml must render; a bare alias, a GovCloud alias ARN, an alias region mismatch and a GovCloud role ARN must fail. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
CI for this PR ran in throwaway draft #73 (closed, branch deleted), since this base has no pull-request Helm trigger.
|
This was referenced Sep 14, 2026
Closed
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-2 review of #68: the collector still rejected the KMS alias ARN the configure page shows, and the role-arn guard accepted GovCloud and China partitions that cannot reach Nullify's commercial bucket and key.
Merge order: this PR into
fix/helm-collector-review(#68), then #68 into #63. The alias grant this relies on ships in connector CloudFormation #64/#69.collector.kms.keyArnacceptsarn:aws:kms:<region>:<12 digits>:alias/<name>and key ARNs includingkey/mrk-…, using the connector CloudFormationAllowedPattern. The region default and mismatch check take the region from either form.key/*; the Terraform module grants only the given ARN. README andvalues.yamlsay the same.ci/eks-kms-alias.yamlandci/eks-kms-mrk.yamlmust render. Must-fail: barealias/…, a GovCloud alias ARN, and an alias region mismatch.arn:aws:iam::only.serviceAccount.requireRoleArn=falseis kept.ci/eks-govcloud-role.yamlis replaced by must-failrole-arn-govcloud.yaml, and the partition mentions are removed from README andvalues.yaml.CI: this branch's base has no pull-request Helm trigger, so the chart was validated in a temporary draft PR that merges it onto #65's follow-up; the run is linked in a comment below.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.