Repository navigation
fix(helm): keep ci/ out of the readonly-access chart package - #76
Closed
tim-thacker-nullify wants to merge 1 commit into
Closed
tim-thacker-nullify wants to merge 1 commit into
tim-thacker-nullify wants to merge 1 commit into
Conversation
- .helmignore excludes ci/, so editing the pre-publish hook or a CI values file no longer changes the packaged contents of a published version (which forced a version bump) and the hook script is not shipped to users. - scripts/test-helm-charts.sh reads ci/*.yaml from the chart directory, so lint and render coverage is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 15, 2026
Closed
tim-thacker-nullify
added a commit
that referenced
this pull request
Sep 15, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #71 (round-3 review, R3-71-1): with no
.helmignore,ci/pre-publish.shand the CI values files shipped in the package, so editing one after 0.1.0 publishes would skip the chart until a version bump.helm-charts/nullify-k8s-readonly-access/.helmignorewithci/.scripts/test-helm-charts.shreadsci/*.yamlfrom the chart directory, and the publish script runs the hook from the directory, so neither needs the files in the package..helmignoreis in the fix(helm): accept KMS alias ARNs in the collector and keep the role ARN commercial #72 follow-up instead, because it needs the 0.4.0 bump there. On this branch the collector is still 0.2.0, which is already published, so adding the file here would change its contents and skip it.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.