Repository navigation
fix(helm): warn instead of failing on a tag with no release asset - #84
Closed
tim-thacker-nullify wants to merge 1 commit into
Closed
tim-thacker-nullify wants to merge 1 commit into
tim-thacker-nullify wants to merge 1 commit into
Conversation
A <chart>-v<version> tag whose release or asset does not exist made recover_from_release die, so every PR's validate leg, publish-dry-run and every release run failed - including before the step that would have created the release. Creating the nullify-k8s-readonly-access-v0.1.0 tag would have wedged all Helm CI. - a missing release, or a release without that asset, is a ::warning:: and the version is dropped from the tagged cross-check; nothing was ever published for it, and the release job publishes it from main if HEAD carries it - an asset whose release records no digest is verified against the tag's tree instead of dying - a digest mismatch, a failed download and a failed content check still fail Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 15, 2026
Closed
tim-thacker-nullify
added a commit
that referenced
this pull request
Sep 15, 2026
fix(helm): warn instead of failing on a tag with no release asset Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-4 review fix for #75 (R4-75-1). A
<chart>-v<version>tag whose release does not exist, or whose release has no<chart>-<version>.tgzasset, maderecover_from_releasedie - killingvalidateon every PR,publish-dry-run, and everyreleaserun before it reached the step that creates the missing release. Creating thenullify-k8s-readonly-access-v0.1.0tag that #79's fallback URL needs would have wedged all Helm CI.::warning::and that version is dropped from the tagged cross-check. Nothing was ever published for it, so there is nothing to unpublish; ifmaincarries that chart version the release job publishes it and creates the release with--verify-tag.LEGACY_TAGSpin, which is the stronger of the two checks.gherror that is not "release not found", a tag not onmain, and an asset whose contents differ from the tag's tree.The cross-check list is now built while recovering (
tagged-checked.tsv) so the post-build assertion covers exactly the versions the site can serve.Merge order: this chain (#65 -> #70 -> #75 -> this) has to reach
mainbefore the collector chain (#68 -> #72 -> #77).main's legacy workflow rebuilds the Pages site from one chart, so merging the collector chain first unpublishes collector 0.2.0.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.