Skip to content

fosrl-badger: init at 1.2.0 - #436769

Merged
SigmaSquadron merged 1 commit into
NixOS:wip-traefik-pluginsfrom
jackrosenberg:push-sxowmopvvvns
Sep 13, 2025
Merged

SigmaSquadron merged 1 commit into
NixOS:wip-traefik-pluginsfrom
jackrosenberg:push-sxowmopvvvns

Conversation

@jackrosenberg

@jackrosenberg jackrosenberg commented Aug 25, 2025

Copy link
Copy Markdown
Member

Things done

Dependency for pangolin. This allows us to version the traefik plugin.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@jackrosenberg jackrosenberg changed the title fosrl-gerbil: init at 1.2.0 fosrl-badger: init at 1.2.0 Aug 25, 2025
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 25, 2025
@jackrosenberg

Copy link
Copy Markdown
Member Author

@ofborg ofborg Bot added the ofborg-internal-error Ofborg encountered an error label Aug 25, 2025
@SigmaSquadron SigmaSquadron reopened this Aug 25, 2025
@SigmaSquadron

Copy link
Copy Markdown
Contributor

@ofborg eval

@adamcstephens

adamcstephens commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

How do you plan to use this with traefik? I'm wondering if we should start a pattern of traefikPlugins since these are all just sources. I've got another plugin I've started using that could go there too. e.g. maybe it's best to build the infrastructure for declarative plugin management with nix provided sources?

@jackrosenberg

jackrosenberg commented Aug 25, 2025

Copy link
Copy Markdown
Member Author

How do you plan to use this with traefik? I'm wondering if we should start a pattern of traefikPlugins since these are all just sources. I've got another plugin I've started using that could go there too. e.g. maybe it's best to build the infrastructure for declarative plugin management with nix provided sources?

I'm currently working on implementing something like this: https://community.traefik.io/t/how-to-install-run-plugin-from-file-offline/23597/2, which IMO would be a much better way to manage traefik plugins overall. This way we can pull traefik plugins into the Nix ecosystem and manage the versions declaratively.

Edit:
Also, since each package knows its <plugin owner> (via pkgs.<name>.owner), we can make the correct folder structure in traefik.

@jackrosenberg
jackrosenberg changed the base branch from master to wip-traefik-plugins August 25, 2025 14:07
@SigmaSquadron

Copy link
Copy Markdown
Contributor

How do you plan to use this with traefik? I'm wondering if we should start a pattern of traefikPlugins since these are all just sources. I've got another plugin I've started using that could go there too. e.g. maybe it's best to build the infrastructure for declarative plugin management with nix provided sources?

I'm doing that as well. I've opened the wip-traefik-plugins branch so we can all push to it and then merge into master when we're done.

@SigmaSquadron

Copy link
Copy Markdown
Contributor

we should start a pattern of traefikPlugins

Do you mean a package set like pythonPackages and friends? I guess we could, but then we'd lose the advantages of by-name.

@adamcstephens

adamcstephens commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

I was thinking a package set with automation based on a simple list of plugins. Not sure by-name is buying us much here. I would look at other package sets such as Grafana plugins, neovim, or maybe terraform for example, and maybe not the complexity of the Python set. :)

@jackrosenberg jackrosenberg mentioned this pull request Aug 25, 2025
13 tasks

@SigmaSquadron SigmaSquadron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final design would be something like this.

{
  lib,
  fetchTraefikPlugin,
}:

fetchTraefikPlugin {
  plugin = "badger";
  owner = "fosrl";
  version = "1.2.0";
  hash = "";

  meta = {
    description = "Traefik plugin that handles authentication for Pangolin resources";
    homepage = "https://plugins.traefik.io/plugins/676da7c6eaa878daeef9c7e9/fossorial-badger";
    license = lib.licenses.mit;
    maintainers = with lib.maintainers; [
      jackr
      sigmasquadron
    ];
  };
}

Comment thread pkgs/by-name/fo/fosrl-badger/package.nix Outdated
@ofborg ofborg Bot removed the ofborg-internal-error Ofborg encountered an error label Aug 26, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 13, 2025
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 13, 2025
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Sep 13, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) label Sep 13, 2025
@SigmaSquadron

Copy link
Copy Markdown
Contributor

So, regarding the package set, I'm not particularly opposed to that, but I would prefer if fosrl-badger specifically is in the top-level of pkgs, in order to simplify the definition of the services.badger.package option in the future refactor of the Pangolin module.

@nixpkgs-ci nixpkgs-ci Bot removed the 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) label Sep 13, 2025
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
@SigmaSquadron
SigmaSquadron merged this pull request into NixOS:wip-traefik-plugins Sep 13, 2025
19 of 20 checks passed
@SigmaSquadron

Copy link
Copy Markdown
Contributor

Merged into #437073 for further testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants