Skip to content

fetchTraefikPlugin: init - #436805

Merged
SigmaSquadron merged 1 commit into
NixOS:wip-traefik-pluginsfrom
SigmaSquadron:push-myvsztumwwku
Aug 26, 2025
Merged

fetchTraefikPlugin: init#436805
SigmaSquadron merged 1 commit into
NixOS:wip-traefik-pluginsfrom
SigmaSquadron:push-myvsztumwwku

Conversation

@SigmaSquadron

Copy link
Copy Markdown
Contributor

This function takes in the provider, owner and plugin name, and outputs a correctly-formatted derivation with the Traefik plugin, which can be symlinkJoined in the /var/lib/traefik/plugins-local folder.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) labels Aug 25, 2025
@nix-owners
nix-owners Bot requested a review from philiptaron August 25, 2025 15:45

@philiptaron philiptaron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for using lib.extendMkDerivation instead.

Comment thread pkgs/build-support/fetchtraefikplugin/default.nix Outdated
This function takes in the provider, owner and plugin name, and outputs
a correctly-formatted derivation with the Traefik plugin, which can be
`symlinkJoin`ed in the `/var/lib/traefik/plugins-local` folder.

Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
@philiptaron

Copy link
Copy Markdown
Contributor

Could you give me an example fetchTraefikPlugin derivation I could try out?

@jackrosenberg

jackrosenberg commented Aug 25, 2025

Copy link
Copy Markdown
Member

Could you give me an example fetchTraefikPlugin derivation I could try out?

https://plugins.traefik.io/plugins/676da7c6eaa878daeef9c7e9/fossorial-badger was the plan. This PR would supersede #436769. Things like crowdsec and geoblock are must-haves too.

@philiptaron

Copy link
Copy Markdown
Contributor

No, I mean, can you give me an expression I can test out in nix repl?

@SigmaSquadron

Copy link
Copy Markdown
Contributor Author

No, I mean, can you give me an expression I can test out in nix repl?

{
  lib,
  fetchTraefikPlugin,
}:

fetchTraefikPlugin {
  plugin = "badger";
  owner = "fosrl";
  version = "1.2.0";
  hash = "";

  meta = {
    description = "Traefik plugin that handles authentication for Pangolin resources";
    homepage = "https://plugins.traefik.io/plugins/676da7c6eaa878daeef9c7e9/fossorial-badger";
    license = lib.licenses.mit;
    maintainers = with lib.maintainers; [
      jackr
      sigmasquadron
    ];
  };
}

@SigmaSquadron
SigmaSquadron dismissed philiptaron’s stale review August 26, 2025 10:44

Needs to be merged for further testing.

@SigmaSquadron
SigmaSquadron merged commit a44583e into NixOS:wip-traefik-plugins Aug 26, 2025
29 of 31 checks passed
@SigmaSquadron
SigmaSquadron deleted the push-myvsztumwwku branch August 26, 2025 10:44
@SigmaSquadron

Copy link
Copy Markdown
Contributor Author

@philiptaron don't worry! This didn't go to master. Since I'm not the only one working on this, we've setup a temporary branch for testing and the final reviews should target #437073.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants