nixos/traefik: add plugins option to install Nix-managed plugins - #436793
Conversation
jackrosenberg
left a comment
There was a problem hiding this comment.
Will need to test this later, but looks good!
66e3ca3 to
0dccd2f
Compare
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
0dccd2f to
3c573e2
Compare
cb00274
into
NixOS:wip-traefik-plugins
|
I'd probably suggest waiting a few days, and giving people time to review, before merging something like this. |
@adamcstephens This isn't master. I asked him to merge both this and other PR's from #436807 :) |
|
I see. Well, it's still not even working, so it's still a bit odd to merge. Traefik is picky about its config, and this breaks configs without plugins. From |
|
Yes, that was the goal of merging it alongside the other PRs. I would never actually merge something as work-in-progress as this into master, which is why the branch is prefixed with |
|
This is slightly more ergonomic than me giving @jackrosenberg commit rights to my Nixpkgs fork and us working outside of the NixOS repo. |
|
Yep. Sorry I missed it wasn’t master. :) |
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.