nixos/pangolin: init - #416148
Conversation
0304479 to
554ab55
Compare
This comment was marked as outdated.
This comment was marked as outdated.
554ab55 to
39fdb93
Compare
SigmaSquadron
left a comment
There was a problem hiding this comment.
- Modules don't have versioning; drop the version information from the module's commit title.
An additional question on upstream support: does pangolin make any distinction between non-breaking and breaking updates? Will all updates be backwards and forward compatible? If the answer to the latter question is no, then we might need to package several Pangolin versions and gate them behind stateVersion in the module.
203bba6 to
d743fb6
Compare
SigmaSquadron
left a comment
There was a problem hiding this comment.
Please add a release note under "new modules" in the NixOS 25.11 release notes.
Like with newt, do a final pass through the option descriptions and examples to ensure everything is properly capitalised, punctuated and the examples make sense.
1e86424 to
4c505ef
Compare
4c505ef to
739307a
Compare
97e321b to
2c2029d
Compare
2c2029d to
c83b14a
Compare
4ec7786 to
7e0fd7c
Compare
7e0fd7c to
a24d60c
Compare
|
@NickCao this is ready for review again, it would be much appreciated if you could take another look :) |
|
Test WIP, waiting on upstream for a way to make an API key. |
|
For anyone wondering the |
|
@ofborg eval |
|
@SigmaSquadron, waiting for upstream to enable a comprehensive test will likely take quite a bit, so for now i'm pushing this back to the basic test. Ready for review again |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
SigmaSquadron
left a comment
There was a problem hiding this comment.
Final nits, promise.
Module looks good to me.
|
@ofborg test pangolin |
1 similar comment
|
@ofborg test pangolin |
SigmaSquadron
left a comment
There was a problem hiding this comment.
I've reproduced a working configuration of Pangolin. It's not the prettiest (the service intentionally fails once and then restarts correctly), but this is very much upstream's issue with the wg0 interface. The module is good enough for the basic features of 1.10. A lot of TODOs still, but they can be fixed during the 26.05 release cycle, as several of them are already being worked on in separate PRs.
Congratulations once more on sticking it through to the end, despite the 200+ comments during the review process. Building NixOS modules for four separate micro-services is a massive achievement. This can be merged once the OfBorg tests pass.
Co-authored-by: Ethan Carter Edwards <ethan@ethancedwards.com>
|
|
Wow, this has been one hell of a ride. This started as a package request, and grew into a monster of a module, with many dependencies. I am truly thankful for the community, many of whom answered my insane questions and corrected my logic. This would not have been possible without @SigmaSquadron. Thanks to your unconditional support, and patient teachings, I can finally answer the question that has been burning in the back of my mind these past months: How many microservices do you need to make Bad Tailscale? 6 :) |
Init Pangolin module for NixOS: pangolin
Depends on
Related to:
pluginsoption, add documentation #437073To test:must reboot after initial setup on remote server
otherwise Newt will give
Ping attempt 1 failed: failed to read ICMP packet: i/o timeoutfixed
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.