fix(gateway): render config with POSIX sed instead of envsubst (self-contained standalones) - #258
Merged
Merged
Conversation
elronbandel
force-pushed
the
elron/fix-gettext-base-standalone
branch
4 times, most recently
from
July 6, 2026 07:42
58ce973 to
310efec
Compare
envsubst is a gateway dependency, but the standalone got it from the benchmark base — so benchmarks on their own base (aider-polyglot, ...) and 3 on external bases (terminal-bench/skills-bench/swe-lancer) had broken standalones (~June-28 regression). Render the config with POSIX sed in the bifrost + litellm start scripts (portkey uses printf) — any userland, no gettext, no per-benchmark package. Refs #257. Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
elronbandel
force-pushed
the
elron/fix-gettext-base-standalone
branch
from
July 6, 2026 07:45
310efec to
584afaa
Compare
elronbandel
added a commit
that referenced
this pull request
Jul 6, 2026
The start scripts render config with sed (#258), so envsubst is unused. - Remove the gettext/gettext-base package from all three gateways (bifrost, portkey, litellm) and the six benchmark bases that carried it only to feed the baked gateway in standalones (#236). - Remove every remaining envsubst mention now that nothing renders with it: the bifrost runtime-deps comment, the models/litellm render comments, the _chart note, and the tool name in gateways/RULES.md rule 4 (+ changelog). - Fix models/litellm's stale UPSTREAM_MODEL doc to the real var, EVAL_MODEL. Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
elronbandel
added a commit
that referenced
this pull request
Jul 6, 2026
…262) The start scripts render config with sed (#258), so envsubst is unused. - Remove the gettext/gettext-base package from all three gateways (bifrost, portkey, litellm) and the six benchmark bases that carried it only to feed the baked gateway in standalones (#236). - Remove every remaining envsubst mention now that nothing renders with it: the bifrost runtime-deps comment, the models/litellm render comments, the _chart note, and the tool name in gateways/RULES.md rule 4 (+ changelog). - Fix models/litellm's stale UPSTREAM_MODEL doc to the real var, EVAL_MODEL. Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone gateway rendered its config with
envsubst(gettext-base), which it got from the benchmark base it layers on. Benchmarks on their own base (aider-polyglot, cybench, …) and 3 on external per-task bases (terminal-bench/skills-bench/swe-lancer) never had it, so their standalone gateway couldn't start — the ~June-28 regression.envsubstis a gateway dependency, not a benchmark's. Render with POSIXsedin the gateway start scripts (bifrost + litellm; portkey usesprintf) — runs in any standalone userland, no gettext, no per-benchmark package.Verified byte-identical to
envsubstacross 165 realistic value combos;sh -n+shellcheckclean. Refs #257 (follow-up: retire the now-unused gettext-base from the gateways + 6 benchmark-base-* images).