refactor(gateways): drop envsubst — dead package and every reference - #262
Merged
Conversation
The start scripts render config with sed (#258), so envsubst is unused. - Remove the gettext/gettext-base package from all three gateways (bifrost, portkey, litellm) and the six benchmark bases that carried it only to feed the baked gateway in standalones (#236). - Remove every remaining envsubst mention now that nothing renders with it: the bifrost runtime-deps comment, the models/litellm render comments, the _chart note, and the tool name in gateways/RULES.md rule 4 (+ changelog). - Fix models/litellm's stale UPSTREAM_MODEL doc to the real var, EVAL_MODEL. Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
elronbandel
force-pushed
the
elron/drop-dead-gettext-base
branch
from
July 6, 2026 09:14
3cff974 to
c0eeb19
Compare
elronbandel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gateway start scripts render config with sed (#258), so
envsubstis dead. This removes it entirely:gettext/gettext-basepackage from all three gateways (bifrost, portkey, litellm) and the six benchmark bases that only carried it to feed the baked gateway in standalones (perf(combos): move gettext-base+curl to the benchmark base (drop per-combo standalone apt) #236).envsubstmention now that nothing renders with it — including generalizinggateways/RULES.mdrule 4 to stop naming a render tool (+ changelog).UPSTREAM_MODELdoc inmodels/litellm, corrected to the real varEVAL_MODEL.No behavior change.
envsubstandUPSTREAM_MODELare now 0 hits repo-wide; hadolint / conftest / helm-lint / trivy green.