Skip to content

fix(gateway): render config with POSIX sed instead of envsubst (self-contained standalones) #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elronbandel merged 1 commit into from
Jul 6, 2026
Merged

fix(gateway): render config with POSIX sed instead of envsubst (self-contained standalones) #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions containers/core/standalone.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ FROM eval-base

# ─── Gateway layer (uniform /opt/gateway/ contract) ──────────────────
COPY --from=model /opt/gateway /opt/gateway
# The gateway's start script needs envsubst (gettext-base) + curl at runtime;
# both now ship in the benchmark base, so this layer stays pure COPY — no
# per-combo apt (that emulated install under QEMU was the combo-build bottleneck).

# ─── OTel collector layer ────────────────────────────────────────────
COPY --from=otel /otelcol /usr/local/bin/otelcol
Expand Down
8 changes: 5 additions & 3 deletions containers/gateways/bifrost/start
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,11 @@ if [ -f "$TEMPLATE" ]; then
OTEL_COLLECTOR_URL="${OTEL_EXPORTER_OTLP_ENDPOINT%/}/v1/traces"
export OTEL_COLLECTOR_URL

# Explicit var list so envsubst leaves bifrost's own $schema key alone.
envsubst '${PROVIDER} ${MODEL_NAME} ${OPENAI_API_BASE} ${OTEL_COLLECTOR_URL}' \
< "$TEMPLATE" > "$CONFIG"
sed -e "s|\${PROVIDER}|${PROVIDER-}|g" \
-e "s|\${MODEL_NAME}|${MODEL_NAME-}|g" \
-e "s|\${OPENAI_API_BASE}|${OPENAI_API_BASE-}|g" \
-e "s|\${OTEL_COLLECTOR_URL}|${OTEL_COLLECTOR_URL-}|g" \
< "$TEMPLATE" > "$CONFIG"
fi

exec /opt/gateway/main \
Expand Down
2 changes: 1 addition & 1 deletion containers/gateways/litellm/start
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ CONFIG=/opt/gateway/config.yaml

if [ -f "$TEMPLATE" ]; then
: "${EVAL_MODEL:?EVAL_MODEL must be set to <provider>/<model>}"
envsubst '${EVAL_MODEL}' < "$TEMPLATE" > "$CONFIG"
sed -e "s|\${EVAL_MODEL}|$EVAL_MODEL|g" < "$TEMPLATE" > "$CONFIG"
fi

# Caddy in background — listens on $PORT, forwards to litellm:4001.
Expand Down