feat(types): add Fulu cell dissemination SSZ types#284
feat(types): add Fulu cell dissemination SSZ types#284lodekeeper-z wants to merge 3 commits intoChainSafe:mainfrom
Conversation
Add PartialDataColumnSidecar, PartialDataColumnPartsMetadata, and PartialDataColumnHeader types from consensus-specs #4558. These types support cell-level dissemination via Gossipsub partial messages, allowing individual cells to be sent instead of full data columns for more efficient data availability sampling. 🤖 Generated with AI assistance
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new SSZ data structures required for the Fulu upgrade's cell dissemination mechanism. These types facilitate more efficient peer-to-peer data transmission by allowing for partial column communication rather than full data columns, aligning the codebase with the latest consensus specifications. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new SSZ container types for cell dissemination in src/consensus_types/fulu.zig, including PartialDataColumnSidecar, PartialDataColumnPartsMetadata, and PartialDataColumnHeader. Feedback focuses on adhering to the repository style guide, specifically ensuring that comments are formatted as complete sentences with proper punctuation and that line lengths do not exceed the 100-column limit.
| row_index: RowIndex, | ||
| }); | ||
|
|
||
| // Cell Dissemination types (consensus-specs #4558) |
There was a problem hiding this comment.
Per the repository style guide (line 304), comments on their own line should be complete sentences with proper capitalization and punctuation. This comment appears to be a section header; please rephrase it as a complete sentence.
// Defines types for cell dissemination (consensus-specs #4558).
References
- Comments should be formatted as complete sentences with proper capitalization and punctuation. (link)
| cells_present_bitmap: ssz.BitListType(preset.MAX_BLOB_COMMITMENTS_PER_BLOCK), | ||
| partial_column: ssz.FixedListType(Cell, preset.MAX_BLOB_COMMITMENTS_PER_BLOCK), | ||
| kzg_proofs: ssz.FixedListType(p.KZGProof, preset.MAX_BLOB_COMMITMENTS_PER_BLOCK), | ||
| // Optional header, only sent on eager pushes |
There was a problem hiding this comment.
Per the repository style guide (line 304), comments on their own line should be complete sentences with proper capitalization and punctuation. Please update this comment to follow that rule.
// The header is optional and is only sent on eager pushes.
References
- Comments should be formatted as complete sentences with proper capitalization and punctuation. (link)
| pub const PartialDataColumnHeader = ssz.VariableContainerType(struct { | ||
| kzg_commitments: ssz.FixedListType(p.KZGCommitment, preset.MAX_BLOB_COMMITMENTS_PER_BLOCK), | ||
| signed_block_header: SignedBeaconBlockHeader, | ||
| kzg_commitments_inclusion_proof: ssz.FixedVectorType(p.Bytes32, preset.KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH), |
There was a problem hiding this comment.
This line exceeds the 100-column limit specified in the repository style guide (line 400). Please reformat it to adhere to the style guide. zig fmt should handle this automatically if you break the line inside the function call's arguments.
kzg_commitments_inclusion_proof: ssz.FixedVectorType(
p.Bytes32,
preset.KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH,
),
References
- All lines must be at most 100 columns long. To wrap a function signature, call or data structure, add a trailing comma and let
zig fmtdo the rest. (link)
From Fulu p2p-interface spec — used for DataColumnSidecarsByRoot requests. 🤖 Generated with AI assistance
- Rephrase section header as complete sentence - Add proper punctuation to inline comment - Break long line to stay within 100-column limit 🤖 Generated with AI assistance
1 participant
Add
PartialDataColumnSidecar,PartialDataColumnPartsMetadata, andPartialDataColumnHeadertypes from consensus-specs #4558 (merged 2026-03-25).These types support cell-level dissemination via Gossipsub partial messages, allowing individual cells to be sent instead of full data columns for more efficient data availability sampling.
New types
PartialDataColumnSidecarPartialDataColumnPartsMetadataPartialDataColumnHeaderSpec reference
🤖 Generated with AI assistance