Skip to content

chore: bump spec test version to v1.6.1#295

Open
lodekeeper-z wants to merge 1 commit intoChainSafe:mainfrom
lodekeeper-z:chore/bump-spec-tests-v1.6.1
Open

chore: bump spec test version to v1.6.1#295
lodekeeper-z wants to merge 1 commit intoChainSafe:mainfrom
lodekeeper-z:chore/bump-spec-tests-v1.6.1

Conversation

@lodekeeper-z
Copy link
Copy Markdown
Contributor

@lodekeeper-z lodekeeper-z commented Mar 28, 2026

Summary

Bump spec test version from v1.6.0-beta.2 to v1.6.1.

Changes between versions (19 commits)

PR Description Impact on us
#4689 Set fork epoch & blob schedule for Fulu Test vector metadata only
#4742 Gossip attestation committee_bits fix Networking, not STF
#4725 SSZ Union integer encoding fix We don't use SSZ unions
#4719-#4741 Gloas spec cleanups (parts 4-6) Gloas only, not implemented
#4715 Version bump to v1.6.0 Version string
#4743 Version bump to v1.6.1 Version string

No state_transition or SSZ test vector changes expected. CI will confirm.

Next step

After this lands, consider bumping to v1.7.0-alpha.4 which includes Fulu cell dissemination test vectors (matches our PR #284).

🤖 Generated with AI assistance

@lodekeeper-z lodekeeper-z requested a review from a team as a code owner March 28, 2026 15:01
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's dependency on the Ethereum consensus-specs test vectors to the latest stable version. This ensures that the local test suite remains aligned with the current specification requirements, incorporating recent fixes and updates to the test data.

Highlights

  • Dependency Update: Updated the consensus-specs test vectors version from v1.6.0-beta.2 to v1.6.1 in the build configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default spec_test_version in build.zig from v1.6.0-beta.2 to v1.6.1. A review comment identifies that this change is incomplete because test/spec/version.txt, which is used as a cache key for CI, still contains the old version string and needs to be regenerated to ensure the correct test vectors are used.

Comment thread build.zig
const option_spec_test_url = b.option([]const u8, "spec_test_url", "") orelse "https://github.com/ethereum/consensus-specs";
options_spec_test_options.addOption([]const u8, "spec_test_url", option_spec_test_url);
const option_spec_test_version = b.option([]const u8, "spec_test_version", "") orelse "v1.6.0-beta.2";
const option_spec_test_version = b.option([]const u8, "spec_test_version", "") orelse "v1.6.1";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While updating the default spec_test_version is correct, this change appears to be incomplete. The file test/spec/version.txt is generated from this value and is used as a cache key for spec tests in CI. It still contains the old version (v1.6.0-beta.2).

Please regenerate test/spec/version.txt by running the appropriate build step (likely related to download_spec_tests) and include the updated file in this pull request to ensure CI uses the correct test vectors.

@lodekeeper-z lodekeeper-z force-pushed the chore/bump-spec-tests-v1.6.1 branch from d1f2164 to dfe369d Compare March 28, 2026 17:32
@lodekeeper-z lodekeeper-z changed the title chore: bump spec test vectors to v1.6.1 chore: bump spec test version to v1.6.1 Mar 28, 2026
@lodekeeper-z lodekeeper-z force-pushed the chore/bump-spec-tests-v1.6.1 branch 2 times, most recently from 2b3849e to 81b6067 Compare March 29, 2026 06:03
Upgrades from v1.6.0-beta.2 to v1.6.1. Changes between versions:
- Fulu fork epoch and blob schedule (#4689)
- Gossip attestation committee_bits fix (#4742)
- Various Gloas spec cleanups (#4719-#4741)
- SSZ Union integer encoding fix (#4725)

None of these affect our state_transition or SSZ test vectors.

🤖 Generated with AI assistance
@lodekeeper-z lodekeeper-z force-pushed the chore/bump-spec-tests-v1.6.1 branch from 9aece0f to 2845ba1 Compare March 29, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant