chore: bump spec test version to v1.6.1#295
chore: bump spec test version to v1.6.1#295lodekeeper-z wants to merge 1 commit intoChainSafe:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's dependency on the Ethereum consensus-specs test vectors to the latest stable version. This ensures that the local test suite remains aligned with the current specification requirements, incorporating recent fixes and updates to the test data. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the default spec_test_version in build.zig from v1.6.0-beta.2 to v1.6.1. A review comment identifies that this change is incomplete because test/spec/version.txt, which is used as a cache key for CI, still contains the old version string and needs to be regenerated to ensure the correct test vectors are used.
| const option_spec_test_url = b.option([]const u8, "spec_test_url", "") orelse "https://github.com/ethereum/consensus-specs"; | ||
| options_spec_test_options.addOption([]const u8, "spec_test_url", option_spec_test_url); | ||
| const option_spec_test_version = b.option([]const u8, "spec_test_version", "") orelse "v1.6.0-beta.2"; | ||
| const option_spec_test_version = b.option([]const u8, "spec_test_version", "") orelse "v1.6.1"; |
There was a problem hiding this comment.
While updating the default spec_test_version is correct, this change appears to be incomplete. The file test/spec/version.txt is generated from this value and is used as a cache key for spec tests in CI. It still contains the old version (v1.6.0-beta.2).
Please regenerate test/spec/version.txt by running the appropriate build step (likely related to download_spec_tests) and include the updated file in this pull request to ensure CI uses the correct test vectors.
d1f2164 to
dfe369d
Compare
2b3849e to
81b6067
Compare
Upgrades from v1.6.0-beta.2 to v1.6.1. Changes between versions: - Fulu fork epoch and blob schedule (#4689) - Gossip attestation committee_bits fix (#4742) - Various Gloas spec cleanups (#4719-#4741) - SSZ Union integer encoding fix (#4725) None of these affect our state_transition or SSZ test vectors. 🤖 Generated with AI assistance
9aece0f to
2845ba1
Compare
Summary
Bump spec test version from
v1.6.0-beta.2tov1.6.1.Changes between versions (19 commits)
No state_transition or SSZ test vector changes expected. CI will confirm.
Next step
After this lands, consider bumping to
v1.7.0-alpha.4which includes Fulu cell dissemination test vectors (matches our PR #284).🤖 Generated with AI assistance