Skip to content

feat(types): add Fulu cell dissemination SSZ types #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lodekeeper-z wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(types): add Fulu cell dissemination SSZ types #284

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be72e84
feat(types): add Fulu cell dissemination SSZ types
lodekeeper-z Mar 27, 2026
07800e0
feat(types): add DataColumnsByRootIdentifier for req/resp
lodekeeper-z Mar 27, 2026
20e63e3
style: address review comments on fulu cell dissemination types
lodekeeper-z Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/consensus_types/fulu.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,26 @@ pub const MatrixEntry = ssz.FixedContainerType(struct {
row_index: RowIndex,
});

// Cell Dissemination types (consensus-specs #4558)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Per the repository style guide (line 304), comments on their own line should be complete sentences with proper capitalization and punctuation. This comment appears to be a section header; please rephrase it as a complete sentence.

// Defines types for cell dissemination (consensus-specs #4558).
References
  1. Comments should be formatted as complete sentences with proper capitalization and punctuation. (link)

pub const PartialDataColumnSidecar = ssz.VariableContainerType(struct {
cells_present_bitmap: ssz.BitListType(preset.MAX_BLOB_COMMITMENTS_PER_BLOCK),
partial_column: ssz.FixedListType(Cell, preset.MAX_BLOB_COMMITMENTS_PER_BLOCK),
kzg_proofs: ssz.FixedListType(p.KZGProof, preset.MAX_BLOB_COMMITMENTS_PER_BLOCK),
// Optional header, only sent on eager pushes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Per the repository style guide (line 304), comments on their own line should be complete sentences with proper capitalization and punctuation. Please update this comment to follow that rule.

// The header is optional and is only sent on eager pushes.
References
  1. Comments should be formatted as complete sentences with proper capitalization and punctuation. (link)

header: ssz.VariableListType(PartialDataColumnHeader, 1),
});

pub const PartialDataColumnPartsMetadata = ssz.VariableContainerType(struct {
available: ssz.BitListType(preset.MAX_BLOB_COMMITMENTS_PER_BLOCK),
requests: ssz.BitListType(preset.MAX_BLOB_COMMITMENTS_PER_BLOCK),
});

pub const PartialDataColumnHeader = ssz.VariableContainerType(struct {
kzg_commitments: ssz.FixedListType(p.KZGCommitment, preset.MAX_BLOB_COMMITMENTS_PER_BLOCK),
signed_block_header: SignedBeaconBlockHeader,
kzg_commitments_inclusion_proof: ssz.FixedVectorType(p.Bytes32, preset.KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH),
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line exceeds the 100-column limit specified in the repository style guide (line 400). Please reformat it to adhere to the style guide. zig fmt should handle this automatically if you break the line inside the function call's arguments.

    kzg_commitments_inclusion_proof: ssz.FixedVectorType(
        p.Bytes32,
        preset.KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH,
    ),
References
  1. All lines must be at most 100 columns long. To wrap a function signature, call or data structure, add a trailing comma and let zig fmt do the rest. (link)

});

// Light client types
pub const LightClientHeader = electra.LightClientHeader;
pub const LightClientBootstrap = electra.LightClientBootstrap;
Expand Down
Loading