Skip to content

[2.6] fix diskann ut #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sre-ci-robot merged 2 commits into from
Aug 19, 2026
Merged

[2.6] fix diskann ut #1781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d338f3
[2.6] fix diskann ut
chasingegg Aug 18, 2026
9839f2c
trigger ci
chasingegg Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/ut/test_diskann.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,14 @@ TEST_CASE("Test DiskANN CalcDistByIDs with all vectors cached", "[diskann]") {
fs::remove_all(kDir);
REQUIRE_NOTHROW(fs::create_directories(kCOSINEIndexDir));

#ifdef KNOWHERE_WITH_CARDINAL
// This case verifies native DiskANN's cached-node file contract.
// Cardinal-backed DISKANN keeps its cache inside Cardinal storage instead.
constexpr const char* diskann_type = "DISKANN_DEPRECATED";
#else
constexpr const char* diskann_type = "DISKANN";
#endif

auto version = GenTestVersionList();
auto base_ds = knowhere::ConvertToDataTypeIfNeeded<knowhere::fp16>(GenDataSet(kNumRows, kDim, 30));
auto base_ptr = static_cast<const knowhere::fp16*>(base_ds->GetTensor());
Expand All @@ -421,7 +429,7 @@ TEST_CASE("Test DiskANN CalcDistByIDs with all vectors cached", "[diskann]") {
std::shared_ptr<milvus::FileManager> file_manager = std::make_shared<milvus::LocalFileManager>();
auto diskann_index_pack = knowhere::Pack(file_manager);
auto diskann =
knowhere::IndexFactory::Instance().Create<knowhere::fp16>("DISKANN", version, diskann_index_pack).value();
knowhere::IndexFactory::Instance().Create<knowhere::fp16>(diskann_type, version, diskann_index_pack).value();
REQUIRE(diskann.Build(nullptr, build_json) == knowhere::Status::success);

knowhere::BinarySet binset;
Expand All @@ -434,7 +442,7 @@ TEST_CASE("Test DiskANN CalcDistByIDs with all vectors cached", "[diskann]") {
deserialize_json["search_cache_budget_gb"] = build_json["search_cache_budget_gb"];

auto loaded_diskann =
knowhere::IndexFactory::Instance().Create<knowhere::fp16>("DISKANN", version, diskann_index_pack).value();
knowhere::IndexFactory::Instance().Create<knowhere::fp16>(diskann_type, version, diskann_index_pack).value();
REQUIRE(loaded_diskann.Deserialize(binset, deserialize_json) == knowhere::Status::success);

std::unique_ptr<uint32_t[]> cached_ids;
Expand Down
Loading