Skip to content

[2.6] fix diskann ut - #1781

Merged
sre-ci-robot merged 2 commits into
zilliztech:2.6from
chasingegg:calcdist-diskann-fix
Aug 19, 2026
Merged

[2.6] fix diskann ut#1781
sre-ci-robot merged 2 commits into
zilliztech:2.6from
chasingegg:calcdist-diskann-fix

Conversation

@chasingegg

@chasingegg chasingegg commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

/kind improvement

similar fix on test_diskann.cc in #1768 , port to 2.6 branch. ut fails with cardinal build after #1764

Signed-off-by: chasingegg <gaoc96@qq.com>
Signed-off-by: chasingegg <gaoc96@qq.com>
@chasingegg
chasingegg force-pushed the calcdist-diskann-fix branch from 2de5a57 to 9839f2c Compare August 19, 2026 02:13
@mergify mergify Bot added dco-passed and removed needs-dco labels Aug 19, 2026

@foxspy foxspy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify

mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@sre-ci-robot
sre-ci-robot merged commit 6df3859 into zilliztech:2.6 Aug 19, 2026
10 checks passed
@chasingegg
chasingegg deleted the calcdist-diskann-fix branch August 19, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants