Skip to content

fix: narrow outdated notification check to duplicate-risk events

4d5449a
Select commit
Loading
Failed to load commit list.
Merged

fix: narrow outdated notification check to duplicate-risk events [WPB-21916] #21403

fix: narrow outdated notification check to duplicate-risk events
4d5449a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 28, 2026 in 0s

45.82% (+0.02%) compared to 43ffa83

View this Pull Request on Codecov

45.82% (+0.02%) compared to 43ffa83

Details

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.82%. Comparing base (43ffa83) to head (4d5449a).
⚠️ Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
...tification/outdatedNotificationStreamEventTypes.ts 81.81% 1 Missing and 1 partial ⚠️
...aries/core/src/notification/notificationService.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #21403      +/-   ##
==========================================
+ Coverage   45.80%   45.82%   +0.02%     
==========================================
  Files        1702     1703       +1     
  Lines       43825    43829       +4     
  Branches     9124     9124              
==========================================
+ Hits        20075    20086      +11     
+ Misses      21482    21475       -7     
  Partials     2268     2268              
Files with missing lines Coverage Δ
...pp/src/script/repositories/event/EventValidator.ts 100.00% <100.00%> (+50.00%) ⬆️
libraries/core/src/notification/index.ts 100.00% <100.00%> (ø)
...aries/core/src/notification/notificationService.ts 53.42% <50.00%> (+4.07%) ⬆️
...tification/outdatedNotificationStreamEventTypes.ts 81.81% <81.81%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.