fix: narrow outdated notification check to duplicate-risk events [WPB-21916]#21403
Open
thisisamir98 wants to merge 6 commits into
Open
fix: narrow outdated notification check to duplicate-risk events [WPB-21916]#21403thisisamir98 wants to merge 6 commits into
thisisamir98 wants to merge 6 commits into
Conversation
The global lastEventDate outdated filter was applied to every notification stream event. When two unrelated conversations share the same millisecond timestamp, a later OTR message can be silently dropped after an earlier one advances lastEventDate. Scope the check to event types that can be handled locally and replayed on the stream (member-join, member-leave, create, rename, protocol-update, message-timer-update, receipt-mode-update, add-permission-update). OTR and MLS content events are no longer filtered this way. Introduce isOutdatedNotificationStreamEvent in core and reuse it from NotificationService and EventValidator.
thisisamir98
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver and
zskhan
as code owners
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/CriticalFlow/channelsCall-TC-8755.spec.ts (❌ 0 failed,
|
zskhan
previously approved these changes
May 29, 2026
e-maad
reviewed
May 29, 2026
…missing-messages-outdated
zskhan
approved these changes
May 29, 2026
|
arjita-mitra
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global lastEventDate outdated filter was applied to every notification stream event. When two unrelated conversations share the same millisecond timestamp, a later OTR message can be silently dropped after an earlier one advances lastEventDate.
Scope the check to event types that can be handled locally and replayed on the stream (member-join, member-leave, create, rename, protocol-update, message-timer-update, receipt-mode-update, add-permission-update). OTR and MLS content events are no longer filtered this way.
Introduce isOutdatedNotificationStreamEvent in core and reuse it from NotificationService and EventValidator.