Skip to content

Make boolean checks explicit without changing how the app behaves [WPB-22420] #21292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
screendriver wants to merge 1 commit into
base: dev
Choose a base branch
from

chore(webapp): continue strict-boolean migration with explicit nullis…

61d92ac
Select commit
Loading
Failed to load commit list.
Draft

Make boolean checks explicit without changing how the app behaves [WPB-22420] #21292

chore(webapp): continue strict-boolean migration with explicit nullis…
61d92ac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 13, 2026 in 0s

44.94% (+0.06%) compared to d59ee66

View this Pull Request on Codecov

44.94% (+0.06%) compared to d59ee66

Details

Codecov Report

❌ Patch coverage is 34.09091% with 348 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.94%. Comparing base (d59ee66) to head (61d92ac).
⚠️ Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
libraries/core/src/account.ts 11.76% 9 Missing and 6 partials ⚠️
...rc/script/components/Conversation/Conversation.tsx 0.00% 11 Missing ⚠️
...lugins/TypeaheadMenuPlugin/TypeaheadMenuPlugin.tsx 0.00% 8 Missing and 1 partial ⚠️
libraries/api-client/src/apiClient.ts 30.76% 6 Missing and 3 partials ⚠️
...pt/components/Modals/PrimaryModal/PrimaryModal.tsx 20.00% 6 Missing and 2 partials ⚠️
...mponents/UserSearchableList/UserSearchableList.tsx 0.00% 8 Missing ⚠️
...rsation/conversationService/conversationService.ts 20.00% 0 Missing and 8 partials ⚠️
libraries/api-client/src/cells/cellsApi.ts 87.93% 4 Missing and 3 partials ⚠️
...mponents/VerificationBadges/VerificationBadges.tsx 0.00% 1 Missing and 5 partials ⚠️
.../script/components/HistoryImport/HistoryImport.tsx 0.00% 6 Missing ⚠️
... and 107 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #21292      +/-   ##
==========================================
+ Coverage   44.87%   44.94%   +0.06%     
==========================================
  Files        1712     1712              
  Lines       44992    45015      +23     
  Branches     9413     9403      -10     
==========================================
+ Hits        20191    20231      +40     
+ Misses      22505    22504       -1     
+ Partials     2296     2280      -16
Files with missing lines Coverage Δ
...bapp/src/script/components/AppLoader/AppLoader.tsx 80.00% <100.00%> (ø)
...ebapp/src/script/components/Avatar/AvatarBadge.tsx 100.00% <100.00%> (ø)
...e/components/UserStatusBadges/UserStatusBadges.tsx 100.00% <100.00%> (ø)
...omponents/Cells/ShareModal/shareModalSerializer.ts 100.00% <100.00%> (ø)
...s/common/useCellsNewNodeForm/cellsNodeFormUtils.ts 100.00% <100.00%> (ø)
apps/webapp/src/script/components/Image/Image.tsx 83.33% <100.00%> (ø)
.../asset/common/useAssetTransfer/useAssetTransfer.ts 100.00% <100.00%> (ø)
...nents/MessagesList/Message/DecryptErrorMessage.tsx 100.00% <100.00%> (ø)
...sagesList/Message/MemberMessage/MessageContent.tsx 61.19% <100.00%> (ø)
...ponents/MessagesList/Message/ReadReceiptStatus.tsx 93.33% <100.00%> (ø)
... and 128 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov